Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: MQL support for subscriptions #73808

Closed
wants to merge 1 commit into from
Closed

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Jul 4, 2024

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

sentry-io bot commented Jul 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/snuba/tasks.py

Function Unhandled Issue
_create_in_snuba SnubaError: HTTP 500 response from Snuba! sentry....
Event Count: 2

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (7b458d4) to head (1e6f348).
Report is 788 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73808   +/-   ##
=======================================
  Coverage   78.11%   78.12%           
=======================================
  Files        6658     6658           
  Lines      297837   297839    +2     
  Branches    51239    51240    +1     
=======================================
+ Hits       232664   232673    +9     
+ Misses      58885    58877    -8     
- Partials     6288     6289    +1     
Files Coverage Δ
src/sentry/snuba/tasks.py 92.17% <33.33%> (-1.64%) ⬇️

... and 5 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Jul 25, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jul 25, 2024
@getsantry getsantry bot closed this Aug 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant