Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats): Display subseries in tooltip #73869

Merged
merged 23 commits into from
Jul 18, 2024

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Jul 5, 2024

This change was previously approved in the PR, but we decided to revert it in order to merge it together with the new doc changes

This PR has undergone significant changes, and I would appreciate a second review!

Goal

Debugging isn't the main focus of the stats page, but users can still use the information there for debugging. Based on feedback, this PR makes the following changes to help with debugging:

  1. Showing client_discard Outcome for Debugging:

    • The client_discard outcome is now available for debugging, but it is initially disabled in the chart because it can be very frequent due to sampling.
  2. Separating invalid Outcome and Updating the UI:

    • The code now separates the invalid outcome from abuse, cardinality_limited, and rate_limited.
    • The UI now shows invalid as a separate outcome, with its own card at the top to highlight its importance.
  3. Replacing dropped with rate_limited:

    • We have replaced dropped (which wasn't a real outcome) with rate_limited.
    • The rate_limited outcome now includes rate_limited, abuse, and cardinality_limited outcomes combined.

Preview

image

Note

We are working on the documentation in the PR

requires https://github.com/getsentry/getsentry/pull/14653

@priscilawebdev priscilawebdev changed the title Priscila/ref/stats/display subseries tooltip feat(stats): Display subseries in tooltip Jul 5, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 5, 2024
@priscilawebdev priscilawebdev marked this pull request as ready for review July 5, 2024 10:29
@priscilawebdev priscilawebdev requested review from a team as code owners July 5, 2024 10:29
@priscilawebdev priscilawebdev requested a review from a team July 5, 2024 10:30
vgrozdanic
vgrozdanic previously approved these changes Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 76.99115% with 26 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (c0c89d2) to head (c367131).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #73869      +/-   ##
==========================================
- Coverage   78.13%   78.13%   -0.01%     
==========================================
  Files        6683     6685       +2     
  Lines      299098   299139      +41     
  Branches    51507    51519      +12     
==========================================
+ Hits       233703   233730      +27     
- Misses      59073    59090      +17     
+ Partials     6322     6319       -3     
Files Coverage Δ
static/app/components/charts/baseChart.tsx 71.42% <ø> (ø)
static/app/utils/theme.tsx 100.00% <ø> (ø)
static/app/views/organizationStats/index.tsx 89.28% <ø> (ø)
...atic/app/views/organizationStats/usageStatsOrg.tsx 82.47% <100.00%> (-0.98%) ⬇️
...app/views/organizationStats/usageStatsProjects.tsx 76.11% <100.00%> (+0.17%) ⬆️
static/app/views/organizationStats/usageTable.tsx 100.00% <100.00%> (ø)
...tatic/app/components/charts/components/tooltip.tsx 6.25% <0.00%> (-0.12%) ⬇️
...c/app/views/organizationStats/usageChart/index.tsx 71.01% <53.84%> (-0.99%) ⬇️
...ic/app/views/organizationStats/mapSeriesToChart.ts 87.93% <87.93%> (ø)
.../app/views/organizationStats/getReasonGroupName.ts 67.85% <67.85%> (ø)

... and 3 files with indirect coverage changes

@brianthi brianthi requested a review from a team July 8, 2024 17:44
dashed
dashed previously approved these changes Jul 8, 2024
@priscilawebdev priscilawebdev requested a review from a team July 11, 2024 08:29
@priscilawebdev priscilawebdev requested review from a team as code owners July 11, 2024 08:29
@priscilawebdev priscilawebdev marked this pull request as draft July 11, 2024 08:29
@priscilawebdev priscilawebdev force-pushed the priscila/ref/stats/display-subseries-tooltip branch from c42d79a to 1b19266 Compare July 18, 2024 12:44

if (
prevDateTime.start !== currDateTime.start ||
prevDateTime.end !== currDateTime.end ||
prevDateTime.period !== currDateTime.period ||
prevDateTime.utc !== currDateTime.utc ||
prevDataCategoryApiName !== currentDataCategoryApiName ||
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matejminar it is fixed here

@priscilawebdev priscilawebdev enabled auto-merge (squash) July 18, 2024 13:02
@priscilawebdev priscilawebdev merged commit d58fc8b into master Jul 18, 2024
43 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/stats/display-subseries-tooltip branch July 18, 2024 13:24
@priscilawebdev priscilawebdev added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jul 18, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 97648a3

getsentry-bot added a commit that referenced this pull request Jul 18, 2024
This reverts commit d58fc8b.

Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>
@priscilawebdev priscilawebdev restored the priscila/ref/stats/display-subseries-tooltip branch July 19, 2024 06:12
priscilawebdev added a commit that referenced this pull request Jul 19, 2024
This reverts commit d58fc8b.

Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants