-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stats): Display subseries in tooltip #73869
Merged
priscilawebdev
merged 23 commits into
master
from
priscila/ref/stats/display-subseries-tooltip
Jul 18, 2024
Merged
feat(stats): Display subseries in tooltip #73869
priscilawebdev
merged 23 commits into
master
from
priscila/ref/stats/display-subseries-tooltip
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
changed the title
Priscila/ref/stats/display subseries tooltip
feat(stats): Display subseries in tooltip
Jul 5, 2024
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Jul 5, 2024
vgrozdanic
previously approved these changes
Jul 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73869 +/- ##
==========================================
- Coverage 78.13% 78.13% -0.01%
==========================================
Files 6683 6685 +2
Lines 299098 299139 +41
Branches 51507 51519 +12
==========================================
+ Hits 233703 233730 +27
- Misses 59073 59090 +17
+ Partials 6322 6319 -3
|
dashed
previously approved these changes
Jul 8, 2024
priscilawebdev
force-pushed
the
priscila/ref/stats/display-subseries-tooltip
branch
from
July 18, 2024 12:44
c42d79a
to
1b19266
Compare
priscilawebdev
commented
Jul 18, 2024
|
||
if ( | ||
prevDateTime.start !== currDateTime.start || | ||
prevDateTime.end !== currDateTime.end || | ||
prevDateTime.period !== currDateTime.period || | ||
prevDateTime.utc !== currDateTime.utc || | ||
prevDataCategoryApiName !== currentDataCategoryApiName || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matejminar it is fixed here
matejminar
approved these changes
Jul 18, 2024
priscilawebdev
added a commit
that referenced
this pull request
Jul 18, 2024
priscilawebdev
added
the
Trigger: Revert
Add to a merged PR to revert it (skips CI)
label
Jul 18, 2024
PR reverted: 97648a3 |
getsentry-bot
added a commit
that referenced
this pull request
Jul 18, 2024
This reverts commit d58fc8b. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>
priscilawebdev
added a commit
that referenced
this pull request
Jul 19, 2024
This reverts commit d58fc8b. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Scope: Frontend
Automatically applied to PRs that change frontend components
Trigger: Revert
Add to a merged PR to revert it (skips CI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was previously approved in the PR, but we decided to revert it in order to merge it together with the new doc changesThis PR has undergone significant changes, and I would appreciate a second review!
Goal
Debugging isn't the main focus of the stats page, but users can still use the information there for debugging. Based on feedback, this PR makes the following changes to help with debugging:
Showing
client_discard
Outcome for Debugging:client_discard
outcome is now available for debugging, but it is initially disabled in the chart because it can be very frequent due to sampling.Separating
invalid
Outcome and Updating the UI:invalid
outcome fromabuse
,cardinality_limited
, andrate_limited
.invalid
as a separate outcome, with its own card at the top to highlight its importance.Replacing
dropped
withrate_limited
:dropped
(which wasn't a real outcome) withrate_limited
.rate_limited
outcome now includesrate_limited
,abuse
, andcardinality_limited
outcomes combined.Preview
Note
We are working on the documentation in the PR
requires https://github.com/getsentry/getsentry/pull/14653