Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slack): remove unused issue assignment logic in SlackActionEndpoint #74151

Merged
merged 1 commit into from
Jul 12, 2024
Merged

chore(slack): remove unused issue assignment logic in SlackActionEndpoint #74151

merged 1 commit into from
Jul 12, 2024

Conversation

cathteng
Copy link
Member

This is replaced by SlackOptionsLoadEndpoint. https://api.slack.com/reference/block-kit/block-elements#external_select

Screenshot 2024-07-11 at 10 41 51

@cathteng cathteng requested a review from a team July 11, 2024 17:42
@cathteng cathteng requested a review from a team as a code owner July 11, 2024 17:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 11, 2024
cathteng
cathteng commented Jul 11, 2024
View reviewed changes
src/sentry/integrations/slack/webhooks/action.py
@@ -708,10 +686,6 @@ def _handle_group_actions(
"unresolved:ongoing",
):
self.on_status(request, identity_user, group, action)
elif (
action.name == "assign"
): # TODO: remove this as it is replaced by the options-load endpoint
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did this because of this comment

saponifi3d
saponifi3d approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only do what the comments tell me to do. :shipit:

isabellaenriquez
isabellaenriquez approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@isabellaenriquez isabellaenriquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@cathteng cathteng merged commit 500ca23 into master Jul 12, 2024
50 checks passed
@cathteng cathteng deleted the cathy/slack/remove-unused-assignment branch July 12, 2024 15:40
priscilawebdev pushed a commit that referenced this pull request Jul 13, 2024
@cathteng @priscilawebdev
chore(slack): remove unused issue assignment logic in SlackActionEndp…
39cca32 
…oint (#74151)
@cathteng cathteng added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jul 18, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 14676fd

getsentry-bot added a commit that referenced this pull request Jul 18, 2024
@getsentry-bot @cathteng
Revert "chore(slack): remove unused issue assignment logic in SlackAc…
14676fd 
…tionEndpoint (#74151)"

This reverts commit 500ca23.

Co-authored-by: cathteng <70817427+cathteng@users.noreply.github.com>
priscilawebdev pushed a commit that referenced this pull request Jul 19, 2024
@getsentry-bot @cathteng @priscilawebdev
Revert "chore(slack): remove unused issue assignment logic in SlackAc…
5dd06d8 
…tionEndpoint (#74151)"

This reverts commit 500ca23.

Co-authored-by: cathteng <70817427+cathteng@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saponifi3d saponifi3d saponifi3d approved these changes

@isabellaenriquez isabellaenriquez isabellaenriquez approved these changes

@ceorourke ceorourke Awaiting requested review from ceorourke

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cathteng @getsentry-bot @saponifi3d @isabellaenriquez