Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(rules): Only fetch necessary data #74229

Merged
merged 12 commits into from
Jul 16, 2024
Merged

ref(rules): Only fetch necessary data #74229

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7cf0474
ref(rules): fetch only whats necessary
ceorourke Jul 12, 2024
e4b3514
add metric counting num groups
ceorourke Jul 12, 2024
85bef4d
refactor
ceorourke Jul 12, 2024
96fc438
pass org id down instead of fetching it later
ceorourke Jul 12, 2024
af306a9
fetch project id
ceorourke Jul 12, 2024
cc8bea0
typing, update some function calls
ceorourke Jul 12, 2024
1c50ce3
Add unit tests, don't reinvent stuff
ceorourke Jul 15, 2024
65d657d
arg rebase
ceorourke Jul 15, 2024
cdceb22
get organization_id defensively
ceorourke Jul 15, 2024
0be28cf
typing
ceorourke Jul 15, 2024
57a84df
get_organization_id_from_groups
ceorourke Jul 16, 2024
62024e4
missed a spot somehow
ceorourke Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/sentry/rules/conditions/event_frequency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,13 +421,18 @@ def batch_query_hook(
"id", "type", "project__organization_id"
)
error_issue_ids, generic_issue_ids = self.get_error_and_generic_group_ids(groups)
organization_id = None
if groups:
group = groups[0]
if len(group) == 3:
organization_id = group[3]
ceorourke marked this conversation as resolved.
Show resolved Hide resolved

if error_issue_ids:
error_sums = self.get_chunked_result(
tsdb_function=self.tsdb.get_sums,
model=get_issue_tsdb_group_model(GroupCategory.ERROR),
group_ids=error_issue_ids,
organization_id=groups[0][2],
organization_id=organization_id,
start=start,
end=end,
environment_id=environment_id,
Expand All @@ -441,7 +446,7 @@ def batch_query_hook(
# this isn't necessarily performance, just any non-error category
model=get_issue_tsdb_group_model(GroupCategory.PERFORMANCE),
group_ids=generic_issue_ids,
organization_id=groups[0][2],
organization_id=organization_id,
start=start,
end=end,
environment_id=environment_id,
Expand Down
Loading