Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update aspnet core onboarding #74299

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Jul 15, 2024

remove profiling from onboarding for now as it's still experimental and there are some issues being resolved for asp.net core ATM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 15, 2024
@vaind vaind changed the title chore: update aspnet core onboarding chore: update aspnet core onboarding [wip] Jul 15, 2024
@vaind vaind marked this pull request as draft July 15, 2024 19:36
@vaind vaind marked this pull request as ready for review July 15, 2024 19:48
@vaind vaind changed the title chore: update aspnet core onboarding [wip] chore: update aspnet core onboarding Jul 16, 2024
@Zylphrex Zylphrex added the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Jul 18, 2024
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Zylphrex Zylphrex merged commit d6ea0d7 into getsentry:master Jul 18, 2024
43 of 45 checks passed
priscilawebdev pushed a commit that referenced this pull request Jul 19, 2024
<!-- Describe your PR here. -->

remove profiling from onboarding for now as it's still experimental and
there are some issues being resolved for asp.net core ATM
<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants