Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(rules): Optimize Group query #74400

Merged
merged 2 commits into from
Jul 17, 2024
Merged

ref(rules): Optimize Group query #74400

merged 2 commits into from
Jul 17, 2024

Conversation

ceorourke
Copy link
Member

@ceorourke ceorourke commented Jul 17, 2024 •
edited
Loading

@ceorourke ceorourke requested a review from a team as a code owner July 17, 2024 00:40
@ceorourke ceorourke requested review from wedamija and a team and removed request for a team July 17, 2024 00:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (7c8bf13) to head (653632c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #74400   +/-   ##
=======================================
  Coverage   78.13%   78.13%           
=======================================
  Files        6672     6672           
  Lines      298583   298618   +35     
  Branches    51389    51390    +1     
=======================================
+ Hits       233303   233332   +29     
- Misses      58995    58996    +1     
- Partials     6285     6290    +5
Files Coverage Δ
src/sentry/rules/processing/delayed_processing.py 88.84% <100.00%> (+0.41%) ⬆️
src/sentry/rules/conditions/event_frequency.py 91.75% <89.74%> (-0.17%) ⬇️

... and 10 files with indirect coverage changes

saponifi3d
saponifi3d approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ceorourke ceorourke merged commit b78aefe into master Jul 17, 2024
52 checks passed
@ceorourke ceorourke deleted the ceorourke/evt-freq-group-query branch July 17, 2024 17:23
priscilawebdev pushed a commit that referenced this pull request Jul 18, 2024
@ceorourke @priscilawebdev
ref(rules): Optimize Group query (#74400)
9fbcc30 
Redo of #74229 that fixes
https://sentry.sentry.io/issues/5612848734
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

@saponifi3d saponifi3d saponifi3d approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceorourke @saponifi3d @wedamija