Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove martini integration #74618

Closed
wants to merge 0 commits into from
Closed

Remove martini integration #74618

wants to merge 0 commits into from

Conversation

ribice
Copy link
Contributor

@ribice ribice commented Jul 21, 2024 •
edited
Loading

@ribice ribice requested a review from a team as a code owner July 21, 2024 09:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 21, 2024
@getsantry getsantry bot added the Stale label Aug 12, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Aug 12, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@priscilawebdev
Copy link
Member

nice! Thanks for keeping a lookout 👏🙂

priscilawebdev
priscilawebdev previously approved these changes Aug 12, 2024
View reviewed changes
@priscilawebdev priscilawebdev enabled auto-merge (squash) August 12, 2024 12:19
@priscilawebdev priscilawebdev dismissed their stale review August 12, 2024 12:51

before we can merge this PR, we need to implement a fallback for people who has martini project implemented

@priscilawebdev
Copy link
Member

priscilawebdev commented Aug 12, 2024 •
edited
Loading

Let's remove 'go-martini' only in static/app/data/platformPickerCategories.tsx and static/app/components/onboarding/frameworkSuggestionModal.tsx, so users can not create a project with this platform anymore

@ribice
Copy link
Contributor Author

ribice commented Aug 12, 2024

Let's remove 'go-martini' only in static/app/data/platformPickerCategories.tsx and static/app/components/onboarding/frameworkSuggestionModal.tsx, so users can not create a project with this platform anymore

Should the text in static/app/gettingStartedDocs/go/martini.tsx remain?

@priscilawebdev
Copy link
Member

@ribice Yes, so users with a Martini project that hasn't been set up yet can still view the instructions for sending events

auto-merge was automatically disabled August 17, 2024 06:13

Head branch was pushed to by a user without write access

@ribice ribice closed this Aug 17, 2024
auto-merge was automatically disabled August 17, 2024 06:13

Pull request was closed

@ribice
Copy link
Contributor Author

ribice commented Aug 17, 2024

@priscilawebdev Opened a new one #76375

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priscilawebdev priscilawebdev priscilawebdev left review comments

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ribice @priscilawebdev