Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: add threadId to continuous profile link #74730

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jul 23, 2024

We need tid (being added to be response) to be able to link to the correct segment in the code where the span/even occurred.

@JonasBa JonasBa requested a review from Zylphrex July 23, 2024 16:01
@JonasBa JonasBa requested a review from a team as a code owner July 23, 2024 16:01
@JonasBa JonasBa changed the title ref: add threadId to profile link ref: add threadId to continuous profile link Jul 23, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Bundle Report

Changes will increase total bundle size by 676 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.17MB 676 bytes ⬆️

@JonasBa JonasBa merged commit 6e76430 into master Jul 24, 2024
42 checks passed
@JonasBa JonasBa deleted the jb/profiling/thread-id branch July 24, 2024 14:55
Copy link

sentry-io bot commented Jul 24, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'thread.id') /performance/trace/:traceSlug/ View Issue

Did you find this useful? React with a 👍 or 👎

@JonasBa JonasBa added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jul 24, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: a9de22b

getsentry-bot added a commit that referenced this pull request Jul 24, 2024
This reverts commit 6e76430.

Co-authored-by: JonasBa <9317857+JonasBa@users.noreply.github.com>
JonasBa added a commit that referenced this pull request Jul 24, 2024
Christinarlong pushed a commit that referenced this pull request Jul 26, 2024
We need tid (being added to be response) to be able to link to the
correct segment in the code where the span/even occurred.
Christinarlong pushed a commit that referenced this pull request Jul 26, 2024
This reverts commit 6e76430.

Co-authored-by: JonasBa <9317857+JonasBa@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants