Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(seer-priority): Add a temporary feature flag to control seer-based priority #74758

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat(seer-priority): Add a temporary feature flag to control seer-based priority #74758

merged 4 commits into from
Jul 23, 2024

Conversation

snigdhas
Copy link
Member

@snigdhas snigdhas commented Jul 23, 2024 •
edited
Loading

Adding a new org-level flag to determine if priority should factor in calculations from Seer and the severity microservice. This flag will need to be moved to features/permanent.py and out of flagpole before we release.

Fixes #74757

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (a61dfdc) to head (0d8cc04).
Report is 18 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #74758   +/-   ##
=======================================
  Coverage   78.15%   78.16%           
=======================================
  Files        6731     6731           
  Lines      300156   300245   +89     
  Branches    51626    51646   +20     
=======================================
+ Hits       234576   234674   +98     
+ Misses      59253    59245    -8     
+ Partials     6327     6326    -1
Files Coverage Δ
src/sentry/features/temporary.py 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

@snigdhas snigdhas changed the title feat(seer-priority): Add a permanent feature flag to control seer-based priority feat(seer-priority): Add a temporary feature flag to control seer-based priority Jul 23, 2024
@snigdhas snigdhas marked this pull request as ready for review July 23, 2024 20:15
@snigdhas snigdhas requested a review from a team as a code owner July 23, 2024 20:15
@snigdhas snigdhas merged commit bff71c4 into master Jul 23, 2024
53 checks passed
@snigdhas snigdhas deleted the snigdha/seer-priority-flag branch July 23, 2024 20:20
@snigdhas snigdhas added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jul 23, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 4cc5752

getsentry-bot added a commit that referenced this pull request Jul 23, 2024
@getsentry-bot @snigdhas
Revert "feat(seer-priority): Add a temporary feature flag to control …
4cc5752 
…seer-based priority (#74758)"

This reverts commit bff71c4.

Co-authored-by: snigdhas <16563948+snigdhas@users.noreply.github.com>
Christinarlong pushed a commit that referenced this pull request Jul 26, 2024
@getsentry-bot @snigdhas @Christinarlong
Revert "feat(seer-priority): Add a temporary feature flag to control …
5c95b8d 
…seer-based priority (#74758)"

This reverts commit bff71c4.

Co-authored-by: snigdhas <16563948+snigdhas@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vartec vartec vartec approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply feature flag to first event severity and priority calculations
3 participants
@snigdhas @getsentry-bot @vartec