Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(similarity): Add re-queue for backfill task when worker is killed #74771

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore(similarity): Add re-queue for backfill task when worker is killed #74771

merged 1 commit into from
Jul 23, 2024

Conversation

jangjodi
Copy link
Member

Add reject_on_worker_lost flag to re-queue the message if the worker is killed

@jangjodi jangjodi requested a review from a team as a code owner July 23, 2024 19:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (e117cd0) to head (e5d643b).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #74771   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files        6733     6733           
  Lines      300307   300307           
  Branches    51649    51649           
=======================================
+ Hits       234732   234734    +2     
+ Misses      59253    59251    -2     
  Partials     6322     6322
Files Coverage Δ
...ping/backfill_seer_grouping_records_for_project.py 91.46% <ø> (ø)

... and 6 files with indirect coverage changes

@jangjodi jangjodi merged commit 2f0a938 into master Jul 23, 2024
51 checks passed
@jangjodi jangjodi deleted the jodi/similarity-backfill-requeue branch July 23, 2024 20:24
@jangjodi jangjodi added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jul 23, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: fc6d859

getsentry-bot added a commit that referenced this pull request Jul 23, 2024
@getsentry-bot @jangjodi
Revert "chore(similarity): Add re-queue for backfill task when worker…
fc6d859 
… is killed (#74771)"

This reverts commit 2f0a938.

Co-authored-by: jangjodi <116035587+jangjodi@users.noreply.github.com>
Christinarlong pushed a commit that referenced this pull request Jul 26, 2024
@getsentry-bot @jangjodi @Christinarlong
Revert "chore(similarity): Add re-queue for backfill task when worker…
e524a94 
… is killed (#74771)"

This reverts commit 2f0a938.

Co-authored-by: jangjodi <116035587+jangjodi@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jangjodi @getsentry-bot @JoshFerge