chore(similarity): Turn on ML grouping for new EA projects #75026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Jul 25, 2024
mrduncan
reviewed
Jul 25, 2024
mrduncan
reviewed
Jul 25, 2024
Comment on lines
+257
to
+260
| assert project.name == "foo" | ||
| assert project.slug == "bar" | ||
| assert project.platform == "python" | ||
| assert project.teams.first() == self.team |
There was a problem hiding this comment.
Why do we need to assert on these? Do they have anything to do with the projectoption? (Same question for the test below.)
There was a problem hiding this comment.
I just included these to ensure that the change doesn't mess up project creation at all
As far as I'm aware, this is the only way. There's a OrganizationProjectsEndpoint, but it doesn't have a post function |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75026 +/- ##
==========================================
- Coverage 78.12% 78.12% -0.01%
==========================================
Files 6745 6745
Lines 301168 301173 +5
Branches 51823 51824 +1
==========================================
+ Hits 235289 235292 +3
- Misses 59555 59556 +1
- Partials 6324 6325 +1
|
|
PR reverted: 6fee71d |
jangjodi
added a commit
that referenced
this pull request
Jul 29, 2024
Add project option to turn on ML similarity grouping for newly created projects that belong to an EA org
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add project option to turn on ML similarity grouping for newly created projects that belong to an EA org