Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): Unpublish ProjectUserReportsEndpoint #75079

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

iamrajjoshi
Copy link
Member

The API is deprecated and Feedback team wants to unpublish it from the api docs. cc @aliu39

@iamrajjoshi iamrajjoshi requested a review from aliu39 July 26, 2024 17:04
@iamrajjoshi iamrajjoshi self-assigned this Jul 26, 2024
@iamrajjoshi iamrajjoshi requested a review from a team July 26, 2024 17:04
@iamrajjoshi iamrajjoshi requested a review from a team as a code owner July 26, 2024 17:04
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jul 26, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will increase total bundle size by 12.62kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.4MB 12.62kB ⬆️

Copy link
Member

@schew2381 schew2381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up that you also need to delete the old tests in apidocs

Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamrajjoshi iamrajjoshi enabled auto-merge (squash) July 26, 2024 17:34
@iamrajjoshi iamrajjoshi merged commit be176fc into master Jul 26, 2024
48 of 49 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/unpublish-user-report-api branch July 26, 2024 18:26
@idosun
Copy link

idosun commented Jul 31, 2024

Hey folks, this API is still referenced in all the SDK docs for user feedback

image

@iamrajjoshi
Copy link
Member Author

Hey folks, this API is still referenced in all the SDK docs for user feedback

image

cc @aliu39

@aliu39 aliu39 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Jul 31, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: dce017f

getsentry-bot added a commit that referenced this pull request Jul 31, 2024
This reverts commit be176fc.

Co-authored-by: aliu39 <159852527+aliu39@users.noreply.github.com>
aliu39 added a commit that referenced this pull request Jul 31, 2024
#75396)

Ref getsentry/sentry-docs#10643
The replay team decided on a call to revert
#75079 because some users may
still need this doc as a reference.

What it looks like:

<img width="1191" alt="Screenshot 2024-07-31 at 3 18 44 PM"
src="https://github.com/user-attachments/assets/6e4b7384-d63e-43be-8ddc-95b8ea2e8833">
<img width="1175" alt="Screenshot 2024-07-31 at 3 27 25 PM"
src="https://github.com/user-attachments/assets/44fe719b-2138-479a-a5cd-0fcbb48a5177">
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants