Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update react-aria dependencies #75091

Closed
wants to merge 2 commits into from
Closed

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jul 26, 2024

No description provided.

@ryan953 ryan953 requested a review from a team as a code owner July 26, 2024 18:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will decrease total bundle size by 4.56kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 28.47MB 4.56kB ⬇️

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (c6effcc) to head (8416a43).
Report is 1012 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #75091       +/-   ##
===========================================
+ Coverage   56.44%   78.12%   +21.68%     
===========================================
  Files        6768     6761        -7     
  Lines      301616   300497     -1119     
  Branches    51907    51752      -155     
===========================================
+ Hits       170237   234770    +64533     
+ Misses     126820    59414    -67406     
- Partials     4559     6313     +1754     
Files with missing lines Coverage Δ
static/app/components/comboBox/index.tsx 86.32% <100.00%> (ø)
.../components/searchQueryBuilder/tokens/combobox.tsx 84.24% <100.00%> (-1.22%) ⬇️

... and 2107 files with indirect coverage changes

@@ -5,6 +5,7 @@ import styled from '@emotion/styled';
import {useComboBox} from '@react-aria/combobox';
import {Item, Section} from '@react-stately/collections';
import {type ComboBoxStateOptions, useComboBoxState} from '@react-stately/combobox';
import type {Key} from '@react-types/shared';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the heck are react-types

Copy link
Member Author

@ryan953 ryan953 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's something from react-aria

lemme findout what i can

it's something from react-aria

All the components depend on these types a lot. for example, from yarn.lock: @react-aria/button depends on @react-types/button and @react-types/shared

"@react-aria/button@^3.9.1":
  version "3.9.1"
  resolved "https://registry.yarnpkg.com/@react-aria/button/-/button-3.9.1.tgz#f76f8a74fe6c6b3ffe1fc446d6f750188a33042e"
  integrity sha512-nAnLMUAnwIVcRkKzS1G2IU6LZSkIWPJGu9amz/g7Y02cGUwFp3lk5bEw2LdoaXiSDJNSX8g0SZFU8FROg57jfQ==
  dependencies:
    "@react-aria/focus" "^3.16.0"
    "@react-aria/interactions" "^3.20.1"
    "@react-aria/utils" "^3.23.0"
    "@react-stately/toggle" "^3.7.0"
    "@react-types/button" "^3.9.1"
    "@react-types/shared" "^3.22.0"
    "@swc/helpers" "^0.5.0"


https://www.npmjs.com/package/@react-types/shared

@priscilawebdev
Copy link
Member

PR looks good, but don't we need the 'package.json' file?

@getsantry
Copy link
Contributor

getsantry bot commented Aug 23, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 23, 2024
@ryan953
Copy link
Member Author

ryan953 commented Aug 28, 2024

This is getting stale. will open a new one

@ryan953 ryan953 closed this Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants