Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(discover): Query specific datasets in events-stats #75118

Conversation

narsaynorath
Copy link
Member

I tried to update the events-stats endpoint to query for the specific datasets but I'm getting this error:

...
  File "/Users/nsaynorath/workspace/sentry/src/sentry/search/events/datasets/discover.py", line 1472, in _resolve_web_vital_function
    raise InvalidSearchQuery("count_web_vitals only supports measurements")
sentry.exceptions.InvalidSearchQuery: count_web_vitals only supports measurements

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/nsaynorath/workspace/sentry/src/sentry/snuba/metrics/extraction.py", line 702, in _extract_aggregate_components
    function, args, _ = _parse_function(aggregate)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/nsaynorath/workspace/sentry/src/sentry/snuba/metrics/extraction.py", line 545, in _parse_function
    raise InvalidSearchQuery(f"Invalid characters in field {aggregate}")
sentry.exceptions.InvalidSearchQuery: Invalid characters in field customtag2
========================================= short test summary info =========================================
FAILED tests/snuba/api/endpoints/test_organization_events_stats_mep.py::OrganizationEventsStatsMetricsEnhancedPerformanceEndpointTestWithOnDemandWidgets::test_top_events_with_transaction_on_demand_passing_widget_id_unsaved_transaction_only - AssertionError: assert None == 101
================================= 1 failed, 82 passed in 67.56s (0:01:07) =================================

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 27, 2024
@narsaynorath narsaynorath force-pushed the nar/feat/discover-split-query-specific-datasets-events-stats branch from a6e4e6b to 78ff982 Compare July 27, 2024 00:57
@narsaynorath narsaynorath changed the base branch from nar/feat/dashboards-discover-split-query-specific-datasets-events to master July 27, 2024 00:57
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (7774556) to head (78ff982).
Report is 1018 commits behind head on master.

Files Patch % Lines
.../sentry/api/endpoints/organization_events_stats.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75118      +/-   ##
==========================================
- Coverage   79.91%   78.09%   -1.82%     
==========================================
  Files        6926     6755     -171     
  Lines      311015   301456    -9559     
  Branches    51861    51861              
==========================================
- Hits       248562   235437   -13125     
+ Misses      62030    59689    -2341     
- Partials      423     6330    +5907     
Files Coverage Δ
.../sentry/api/endpoints/organization_events_stats.py 91.48% <0.00%> (-2.27%) ⬇️

... and 1764 files with indirect coverage changes

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant