-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trace_related): Use global_views whitelist for events endpoint #75174
Closed
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
759a58b
Revert "fix(related_issues): Orgs with open membership should always …
armenzg a190038
Only change behaviour for the events endpoint
armenzg 15924e6
Add any back
armenzg a95b891
Use referrer to whitelistttttttt
armenzg deaebc7
Fix any
armenzg 20a2a3a
TODO comment
armenzg 6ce7642
Adjust inter diff
armenzg 99fb7be
Update src/sentry/api/endpoints/organization_events.py
armenzg 4fef2dc
allowlist
armenzg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,6 +165,17 @@ def test_performance_view_feature(self): | |
assert response.status_code == 200 | ||
assert len(response.data["data"]) == 1 | ||
|
||
def test_multi_project_feature_gate_rejection(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This adds the original test back. |
||
team = self.create_team(organization=self.organization, members=[self.user]) | ||
|
||
project = self.create_project(organization=self.organization, teams=[team]) | ||
project2 = self.create_project(organization=self.organization, teams=[team]) | ||
|
||
query = {"field": ["id", "project.id"], "project": [project.id, project2.id]} | ||
response = self.do_request(query) | ||
assert response.status_code == 400 | ||
assert "events from multiple projects" in response.data["detail"] | ||
|
||
def test_multi_project_feature_gate_replays(self): | ||
team = self.create_team(organization=self.organization, members=[self.user]) | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to my original PR.
This has been moved down below: