fix(ecosystems): Disables window close for integration pipeline dialog #75307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75307 +/- ##
=======================================
Coverage 78.21% 78.21%
=======================================
Files 6775 6775
Lines 302013 302013
Branches 51963 51963
=======================================
Hits 236217 236217
+ Misses 59443 59442 -1
- Partials 6353 6354 +1 |
iamrajjoshi
approved these changes
Jul 31, 2024
| @@ -14,7 +14,6 @@ | |||
| if (window.opener) { | |||
| window.opener.postMessage({{ payload|to_json }}, {{ document_origin|safe }}); | |||
| } | |||
| window.close(); | |||
There was a problem hiding this comment.
do you have any idea why this was here in the first place?
There was a problem hiding this comment.
I have no clue why. I'm guessing as a convenience thing when the pipeline succeeds, but it was never intended to close for failures.
GabeVillalobos
deleted the
gv/disable-window-closing-for-integration-pipeline-dialogs
branch
GabeVillalobos
added
the
Trigger: Revert
|
PR reverted: 70aca29 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the dialog window from immediately closing when the integration pipeline is finished. This currently happens, regardless of the success of the operation which results in us dropping errors messages when we should be displaying them to the customer.