-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hybrid-cloud): Resubmits Pydantic v2.7 upgrade #75311
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75311 +/- ##
==========================================
+ Coverage 78.18% 78.21% +0.02%
==========================================
Files 6775 6775
Lines 302017 302019 +2
Branches 51963 51963
==========================================
+ Hits 236134 236224 +90
+ Misses 59513 59440 -73
+ Partials 6370 6355 -15
|
any context on what's changed since last attempt? and why the last one failed? |
the api diff also appears to be broken 🤔 |
@asottile-sentry For some reason, a pod was OOMing in S4S after the upgrade. It's unclear why this was occurring as this particular pod shouldn't have been affected, but we're planning to try scaling the pod up a bit to see if this alleviates the issue. As for the API diff errors, it looks like pydantic's generated JSON schema handles nullable fields differently in V2 than it did in V1 Pydantic docs on the changes
|
cool just checking -- more memory makes sense to me given pydantic 2's move to a rust extension over cython so I wouldn't be surprised if a few workers need slight bumps (especially if they're running particularly hot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mulligan of PR #74770
This PR upgrades pydantic and updates the model configs we use for RPC methods to conform with the new version.
This PR does not address deprecation warnings, which will be handled in a series of follow-up commits to both Sentry and GetSentry.