Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: don't call hidden authors collapsed #75338

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Jul 31, 2024

closes #75327

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@keradus keradus requested a review from a team as a code owner July 31, 2024 14:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 31, 2024
Copy link

@osxd osxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks legit (im not sure about translations, though, let's hope other languages uses softer collapse statements 😅)

@schew2381 schew2381 added the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Jul 31, 2024
Copy link
Member

@schew2381 schew2381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making the change 👍

@schew2381
Copy link
Member

@keradus Ah looks like the linter is complaining, could you change lines 89-93 to be one line like

{tn('Show %s other author', 'Show %s other authors', numberOfHiddenItems)}

@github-actions github-actions bot removed the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Aug 1, 2024
@keradus
Copy link
Contributor Author

keradus commented Aug 1, 2024

thanks for the hint @schew2381 , applied.

I was wondering what style violation it was - I couldn't find it on CI log and didn't set up the tooling on local machine to validate myself.
maybe opportunity to show that diff on CI?

thanks for hint, anyway! hope it's green now ;)

@schew2381 schew2381 added the Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests label Aug 2, 2024
@schew2381 schew2381 merged commit 46b1262 into getsentry:master Aug 2, 2024
40 of 42 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2024
@keradus keradus deleted the patch-1 branch August 21, 2024 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "collapsed engineers" from the Commit to a friendlier title
3 participants