Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use new onboarding component #75345

Merged
merged 10 commits into from
Aug 1, 2024
Merged

ref: use new onboarding component #75345

merged 10 commits into from
Aug 1, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jul 31, 2024

Uses the new onboarding component that does not fetch onboarding from the docs.

@JonasBa JonasBa requested a review from Zylphrex July 31, 2024 16:07
@JonasBa JonasBa requested review from a team as code owners July 31, 2024 16:07
@JonasBa JonasBa added the Do Not Merge Don't merge label Jul 31, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (4cc7fc9) to head (f744247).
Report is 69 commits behind head on master.

Files Patch % Lines
...omponents/profiling/profilingOnboardingSidebar.tsx 21.42% 22 Missing ⚠️
...ng/gettingStartedDoc/utils/profilingOnboarding.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75345      +/-   ##
==========================================
+ Coverage   74.65%   78.16%   +3.50%     
==========================================
  Files        6780     6789       +9     
  Lines      302142   302538     +396     
  Branches    51997    52058      +61     
==========================================
+ Hits       225578   236488   +10910     
+ Misses      69994    59669   -10325     
+ Partials     6570     6381     -189     
Files Coverage Δ
.../gettingStartedDoc/utils/useLoadGettingStarted.tsx 72.22% <ø> (ø)
static/app/components/sidebar/index.tsx 80.45% <ø> (ø)
...ng/gettingStartedDoc/utils/profilingOnboarding.tsx 50.00% <0.00%> (-50.00%) ⬇️
...omponents/profiling/profilingOnboardingSidebar.tsx 11.84% <21.42%> (ø)

... and 803 files with indirect coverage changes

Copy link

codecov bot commented Aug 1, 2024

Bundle Report

Changes will increase total bundle size by 11.52kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.61MB 11.52kB ⬆️

static/app/utils/profiling/platforms.tsx Outdated Show resolved Hide resolved
@JonasBa JonasBa enabled auto-merge (squash) August 1, 2024 20:18
@JonasBa JonasBa merged commit ab15735 into master Aug 1, 2024
41 checks passed
@JonasBa JonasBa deleted the jb/profiling/new-onboarding branch August 1, 2024 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants