Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(relay): Instrument flaky test #75361

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Jul 31, 2024

test_histogram_outliers became flaky after getsentry/relay#3863.

Add info to the assert to get more insights.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.18%. Comparing base (3a2f433) to head (576e9fc).
Report is 507 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #75361       +/-   ##
===========================================
+ Coverage   54.36%   78.18%   +23.82%     
===========================================
  Files        5669     6745     +1076     
  Lines      238522   301056    +62534     
  Branches    40867    51801    +10934     
===========================================
+ Hits       129675   235386   +105711     
+ Misses     107370    59292    -48078     
- Partials     1477     6378     +4901     

see 2378 files with indirect coverage changes

@jjbayer jjbayer merged commit 4846445 into master Aug 1, 2024
48 checks passed
@jjbayer jjbayer deleted the test/relay-flaky-histogram-outliers branch August 1, 2024 07:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants