Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(data-secrecy): Remove bitflag update from Org Details Endpoint #75449

Merged
merged 1 commit into from
Aug 1, 2024
Merged

chore(data-secrecy): Remove bitflag update from Org Details Endpoint #75449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/sentry/api/endpoints/organization_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,6 @@ def save(self):
org.flags.require_email_verification = data["requireEmailVerification"]
if "allowMemberProjectCreation" in data:
org.flags.disable_member_project_creation = not data["allowMemberProjectCreation"]
if "allowSuperuserAccess" in data:
org.flags.prevent_superuser_access = not data["allowSuperuserAccess"]
if "name" in data:
org.name = data["name"]
if "slug" in data:
Expand All @@ -531,7 +529,6 @@ def save(self):
"require_2fa": org.flags.require_2fa.is_set,
"codecov_access": org.flags.codecov_access.is_set,
"disable_member_project_creation": org.flags.disable_member_project_creation.is_set,
"prevent_superuser_access": org.flags.prevent_superuser_access.is_set,
},
}

Expand Down
4 changes: 0 additions & 4 deletions tests/sentry/api/endpoints/test_organization_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ def test_various_options(self, mock_get_repositories):

assert org.flags.early_adopter
assert org.flags.codecov_access
assert org.flags.prevent_superuser_access
assert not org.flags.allow_joinleave
assert org.flags.disable_shared_issues
assert org.flags.enhanced_privacy
Expand Down Expand Up @@ -503,9 +502,6 @@ def test_various_options(self, mock_get_repositories):
assert "to {}".format(data["openMembership"]) in log.data["allow_joinleave"]
assert "to {}".format(data["isEarlyAdopter"]) in log.data["early_adopter"]
assert "to {}".format(data["codecovAccess"]) in log.data["codecov_access"]
assert (
"to {}".format(not data["allowSuperuserAccess"]) in log.data["prevent_superuser_access"]
)
assert "to {}".format(data["enhancedPrivacy"]) in log.data["enhanced_privacy"]
assert "to {}".format(not data["allowSharedIssues"]) in log.data["disable_shared_issues"]
assert "to {}".format(data["require2FA"]) in log.data["require_2fa"]
Expand Down
Loading