Filter out in-app frames when matching for CODEOWNERS #75588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
alxckn
force-pushed
the
codeowners_on_in_app_frames_only
branch
from
f2f8f61
to
82b3bbf
Compare
alxckn
force-pushed
the
codeowners_on_in_app_frames_only
branch
from
82b3bbf
to
ddd2d10
Compare
JoshFerge
added
the
Trigger: getsentry tests
fix type of func
github-actions
bot
removed
the
Trigger: getsentry tests
JoshFerge
added
the
Trigger: getsentry tests
|
thank you for the contribution @alxckn! this change looks good to me. I added one test case and will go ahead and merge after CI passes! |
JoshFerge
approved these changes
Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation for ownership rules, about CODEOWNERS file evaluation on an event's frames, it is stated that "Sentry evaluates an event’s in-app frames against the rules".
As discussed in this issue, this does not seem to be in fact the case (see this comment with a reproduction scenario specifically).
This PR proposes changes to ensure the clause is respected for CODEOWNERS matchers. When matching frames, if they are explicitely not in app (
frame.get("in_app" == False), they will be ignored.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.