Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slack): fix disappearing tags for issue button actions #75789

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(slack): fix disappearing tags for issue button actions #75789

merged 1 commit into from
Aug 8, 2024

Conversation

cathteng
Copy link
Member

@cathteng cathteng commented Aug 7, 2024 •
edited
Loading

Fix tags disappearing when resolving/archiving/unarchiving an issue through a Slack message. Pass the tags to the View's private_metadata, so when somebody takes an action through the modal, we can read the data from the view_submission event.

Fix

Screen.Recording.2024-08-08.at.09.43.03.mov

Before

Screen.Recording.2024-08-08.at.09.44.19.mov

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 7, 2024
Base automatically changed from cathy/slack/actually-fix-disappearing-tags to master August 8, 2024 16:05
@cathteng cathteng force-pushed the cathy/slack/fix-disappearing-tags-issue-action branch from 4da2da2 to 62ef9f6 Compare August 8, 2024 16:13
@cathteng cathteng marked this pull request as ready for review August 8, 2024 16:38
@cathteng cathteng requested a review from a team as a code owner August 8, 2024 16:38
@cathteng cathteng requested a review from a team August 8, 2024 16:45
iamrajjoshi
iamrajjoshi approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but this has me thinking how would we even abstract this away into the spec? i feel like these are such fine details that might work differently between integrations

@cathteng
Copy link
Member Author

cathteng commented Aug 8, 2024

@iamrajjoshi i don't think we'd abstract this far deep into the details, you'd have to go more broad

@cathteng cathteng merged commit eb98a3d into master Aug 8, 2024
50 checks passed
@cathteng cathteng deleted the cathy/slack/fix-disappearing-tags-issue-action branch August 8, 2024 17:26
@sentry-io Sentry.io
Copy link

sentry-io bot commented Aug 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 'tags' /extensions/slack/action/ View Issue

Did you find this useful? React with a 👍 or 👎

@Zylphrex Zylphrex added the Trigger: Revert add to a merged PR to revert it (skips CI) label Aug 8, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 1232ab7

getsentry-bot added a commit that referenced this pull request Aug 8, 2024
@getsentry-bot @Zylphrex
Revert "fix(slack): fix disappearing tags for issue button actions (#…
1232ab7 
…75789)"

This reverts commit eb98a3d.

Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
@cathteng cathteng restored the cathy/slack/fix-disappearing-tags-issue-action branch August 8, 2024 22:38
@cathteng cathteng mentioned this pull request Aug 8, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamrajjoshi iamrajjoshi iamrajjoshi approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cathteng @getsentry-bot @iamrajjoshi @Zylphrex