feat(issue-resolve): stop using feature flag organizations:resolve-in-upcoming-release on the backend #75901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
scttcper
approved these changes
Aug 14, 2024
scttcper
added
the
Trigger: getsentry tests
|
@scttcper could you merge this? I don't have permission to do it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature flag
organizations:resolve-in-upcoming-releasehas been there for some time (it was added while I was still a Sentry employee, lol). I'm going to assume it's been rolled out internally at least. But it's time to enable the feature globally so that people can start using it. I've tested it locally and seems to work fine. The purpose of this feature is thatResolve in Next Releasedoesn't work well if the latest event for an issue isn't the current release because if a new event comes on that new release, it automatically regresses. This was done because that sort of logic is needed for semver releases where current release might have different branches (e.x: an issue that appears in release 7.0 shouldn't be marked as resolved if release 6.1 happens, only if 7.1 happens). Here is the rollout plan.Resolve in Upcoming Releasefeature on the backendResolve in Upcoming Releasefeature on the frontend and updateHere is what the feature looks like in the UI when it's enabled:
Here is what happens when you resolve the feature in a release then a new release gets released:
Related PR from @roggenkemper: #70990