Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move function out of receivers #76255

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

schew2381
Copy link
Member

Need to move more imports out of receivers in order for getsentry imports to work with upcoming default metric alert changes

@schew2381 schew2381 requested a review from a team August 15, 2024 09:19
@schew2381 schew2381 self-assigned this Aug 15, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 15, 2024
src/sentry/utils/db.py Outdated Show resolved Hide resolved
This reverts commit 482790b.
@schew2381 schew2381 marked this pull request as draft August 15, 2024 10:45
@schew2381 schew2381 marked this pull request as ready for review August 15, 2024 11:34
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@schew2381 schew2381 merged commit da87527 into master Aug 15, 2024
48 of 49 checks passed
@schew2381 schew2381 deleted the seiji/chore/move-function-out-of-receiver branch August 15, 2024 17:13
@schew2381 schew2381 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Aug 15, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 2e9f17e

getsentry-bot added a commit that referenced this pull request Aug 15, 2024
This reverts commit da87527.

Co-authored-by: schew2381 <67301797+schew2381@users.noreply.github.com>
@schew2381 schew2381 restored the seiji/chore/move-function-out-of-receiver branch August 15, 2024 17:30
schew2381 added a commit that referenced this pull request Aug 15, 2024
Move stuff out of receivers second try after:
#76255
Just making it backwards compatible instead cuz requires didn't work

getsentry PR moving imports:
getsentry/getsentry#14925
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants