Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackweek(kafkatasks): add kafkatasks postgres model #76394

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

victoria-yining-huang
Copy link
Contributor

  • Empty files!
  • We'll need migrations probably
  • Start sketching registry/namespace and decorator
  • add kafkatasks model

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

❌ 46 Tests Failed:

Tests completed Failed Passed Skipped
19888 46 19842 135
View the top 3 failed tests by shortest run time
tests.sentry.db.test_silo_models test_models_have_silos
Stack Traces | 0.06s run time
#x1B[1m#x1B[.../sentry/db/test_silo_models.py#x1B[0m:17: in test_models_have_silos
    validate_models_have_silos(decorator_exemptions)
#x1B[1m#x1B[.../sentry/testutils/silo.py#x1B[0m:546: in validate_models_have_silos
    silo_limit = _model_silo_limit(model)
#x1B[1m#x1B[.../sentry/testutils/silo.py#x1B[0m:109: in _model_silo_limit
    raise ValueError(
#x1B[1m#x1B[31mE   ValueError: <class 'sentry.taskworker.models.PendingTasks'> is missing a silo limit, add a silo_model decorate to indicate its placement#x1B[0m
tests.sentry.backup.test_dependencies test_truncate
Stack Traces | 0.061s run time
#x1B[1m#x1B[.../sentry/backup/test_dependencies.py#x1B[0m:81: in test_truncate
    assert_model_dependencies(expect, actual)
#x1B[1m#x1B[.../sentry/backup/test_dependencies.py#x1B[0m:42: in assert_model_dependencies
    raise AssertionError(
#x1B[1m#x1B[31mE   AssertionError: Model dependency graph does not match fixture. This means that you have changed the model dependency graph in some load bearing way. If you are seeing this in CI, and the dependency changes are intentional, please run `bin/generate-model-dependency-fixtures` and re-upload:#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -48,6 +48,7 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE      "sentry_userrole",#x1B[0m
#x1B[1m#x1B[31mE      "sentry_userrole_users",#x1B[0m
#x1B[1m#x1B[31mE      "social_auth_usersocialauth",#x1B[0m
#x1B[1m#x1B[31mE   +  "taskworker_pendingtasks",#x1B[0m
#x1B[1m#x1B[31mE      "uptime_uptimesubscription",#x1B[0m
#x1B[1m#x1B[31mE      "sentry_savedsearch",#x1B[0m
#x1B[1m#x1B[31mE      "sentry_relocation",#x1B[0m
tests.sentry.backup.test_dependencies test_sorted
Stack Traces | 0.065s run time
#x1B[1m#x1B[.../sentry/backup/test_dependencies.py#x1B[0m:72: in test_sorted
    assert_model_dependencies(expect, actual)
#x1B[1m#x1B[.../sentry/backup/test_dependencies.py#x1B[0m:42: in assert_model_dependencies
    raise AssertionError(
#x1B[1m#x1B[31mE   AssertionError: Model dependency graph does not match fixture. This means that you have changed the model dependency graph in some load bearing way. If you are seeing this in CI, and the dependency changes are intentional, please run `bin/generate-model-dependency-fixtures` and re-upload:#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -48,6 +48,7 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE      "sentry.userrole",#x1B[0m
#x1B[1m#x1B[31mE      "sentry.userroleuser",#x1B[0m
#x1B[1m#x1B[31mE      "social_auth.usersocialauth",#x1B[0m
#x1B[1m#x1B[31mE   +  "taskworker.pendingtasks",#x1B[0m
#x1B[1m#x1B[31mE      "uptime.uptimesubscription",#x1B[0m
#x1B[1m#x1B[31mE      "sentry.savedsearch",#x1B[0m
#x1B[1m#x1B[31mE      "sentry.relocation",#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

- Fix warnings and TODOs related to datetimes.
- Fix startup error in strategy_factory.
- Simplified logging configuration
@getsantry
Copy link
Contributor

getsantry bot commented Sep 13, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants