feat(rr6): Tie react-router 6 to it's feature flag #76470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76470 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 6894 6894
Lines 306749 306752 +3
Branches 52794 52795 +1
==========================================
Hits 239757 239757
- Misses 60604 60607 +3
Partials 6388 6388 |
| @@ -67,6 +67,20 @@ | |||
| // | |||
| // [1]: https://sentry.io/careers/ | |||
|
|
|||
| // TODO(__SENTRY_USING_REACT_ROUTER_SIX): Very early on check if we're running | |||
| // using the react-router 6 faeture flag so we can enable ths beefore the app | |||
There was a problem hiding this comment.
Suggested change
| // using the react-router 6 faeture flag so we can enable ths beefore the app | |
| // using the react-router 6 feature flag so we can enable this before the app |
| // boots. | ||
| // | ||
| try { | ||
| // @ts-expect-error features is an array at this point. It is unfortuantely |
There was a problem hiding this comment.
Suggested change
| // @ts-expect-error features is an array at this point. It is unfortuantely | |
| // @ts-expect-error features is an array at this point. It is unfortunately |
There was a problem hiding this comment.
will cleanup later 👍
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-rr6-tie-react-router-6-to-it-s-feature-flag
branch
from
6e625b5
to
fe2d342
Compare
priscilawebdev
approved these changes
Aug 28, 2024
evanpurkhiser
deleted the
evanpurkhiser/feat-rr6-tie-react-router-6-to-it-s-feature-flag
branch
ArthurKnaus
pushed a commit
that referenced
this pull request
Aug 29, 2024
This will allow us to slow roll react router 6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to slow roll react router 6