Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codeowners): Clean up CODEOWNERS #76498

Closed
wants to merge 1 commit into from

Conversation

mrduncan
Copy link
Member

@mrduncan mrduncan commented Aug 22, 2024

The result of a hackweek project which didn't make it too far...

More details below, in general these fixes fall into two buckets:

  • Duplicate patterns: Later rules override earlier rules so the first ones were being ignored.
  • Missing files: Rules which never applied to any files. These files were some combination of moved and deleted.

Fixes:

$ codeberg lint ../sentry | grep -v NoUnownedFiles
[NoMissingFiles] 19: /src/sentry/utils/snql.py does not match any files
[NoMissingFiles] 60: /src/sentry/web/frontend/auth_organization_id_login.py does not match any files
[NoMissingFiles] 98: /src/sentry/api/endpoints/relocation/ does not match any files
[NoMissingFiles] 99: /src/sentry/api/serialiers/models/relocation/ does not match any files
[NoMissingFiles] 100: /src/sentry/models/relocation/ does not match any files
[NoMissingFiles] 104: /tests/sentry/api/endpoints/relocation does not match any files
[NoMissingFiles] 106: /tests/sentry/api/serializer/test_relocation.py does not match any files
[NoMissingFiles] 118: .vercel.json does not match any files
[NoMissingFiles] 119: /.githib/worksflows/frontend.yml does not match any files
[NoMissingFiles] 146: /src/sentry/utils/monitors.py does not match any files
[NoMissingFiles] 147: /tests/sentry/utils/test_monitors.py does not match any files
[NoMissingFiles] 162: /src/sentry/api/endpoints/internal/integration_proxy.py does not match any files
[NoMissingFiles] 164: /src/sentry/models/outbox.py does not match any files
[NoMissingFiles] 165: /src/sentry/tasks/deliver_from_outbox.py does not match any files
[NoMissingFiles] 225: /tests/snuba/api/endpoints/test_organization_events_trends_v2.py does not match any files
[NoMissingFiles] 313: /src/sentry/utils/profiling.py does not match any files
[NoMissingFiles] 368: /src/sentry/tasks/weekly_reports.py does not match any files
[NoMissingFiles] 390: /src/sentry/models/organizationoption.py does not match any files
[NoMissingFiles] 392: /src/sentry/models/projectoption.py does not match any files
[NoDuplicatePatterns] 412: /src/sentry/web/frontend/auth_login.py duplicated on line 58
[NoMissingFiles] 421: /tests/sentry/api/test_scim*.py does not match any files
[NoMissingFiles] 445: /tests/sentry/api/endpoints/test_projects_metrics_visibility.py does not match any files
[NoMissingFiles] 451: /src/sentry/api/endpoints/organization_ddm.py does not match any files
[NoMissingFiles] 452: /tests/sentry/api/endpoints/test_organization_ddm_meta.py does not match any files
[NoMissingFiles] 457: /src/sentry/api/endpoints/projects_metrics.py does not match any files
[NoDuplicatePatterns] 477: /src/sentry/snuba/metrics/ duplicated on line 27
[NoMissingFiles] 482: /static/app/actionCreators/metrics.spec.tsx does not match any files
[NoMissingFiles] 492: /static/app/views/performance/landing/dynamicSamplingMetricsAccuracy.spec.tsx does not match any files
[NoMissingFiles] 493: /static/app/views/performance/landing/dynamicSamplingMetricsAccuracyAlert.tsx does not match any files
[NoMissingFiles] 554: /static/app/components/modals/autofixSetupModal.spec.tsx does not match any files
[NoMissingFiles] 555: /static/app/components/modals/autofixSetupModal.tsx does not match any files
[NoMissingFiles] 568: /src/sentry/tasks/low_priority_symbolication.py does not match any files
[NoMissingFiles] 570: /tests/sentry/tasks/test_low_priority_symbolication.py does not match any files
[NoMissingFiles] 571: /src/sentry/tasks/reprocessing.py does not match any files
[NoMissingFiles] 580: /src/sentry/tasks/invite_missing_org_members.py does not match any files
[NoMissingFiles] 582: /src/sentry/tasks/integrations/github/pr_comment.py does not match any files

The result of a hackweek project which didn't make it too far...

More details below, in general these fixes fall into two buckets:
- Duplicate patterns: Later rules override earlier rules so the first
  ones were being ignored.
- Missing files: Rules which never applied to any files. These files
  were some combination of moved and deleted.

```
$ codeberg lint ../sentry | grep -v NoUnownedFiles
[NoMissingFiles] 19: /src/sentry/utils/snql.py does not match any files
[NoMissingFiles] 60: /src/sentry/web/frontend/auth_organization_id_login.py does not match any files
[NoMissingFiles] 98: /src/sentry/api/endpoints/relocation/ does not match any files
[NoMissingFiles] 99: /src/sentry/api/serialiers/models/relocation/ does not match any files
[NoMissingFiles] 100: /src/sentry/models/relocation/ does not match any files
[NoMissingFiles] 104: /tests/sentry/api/endpoints/relocation does not match any files
[NoMissingFiles] 106: /tests/sentry/api/serializer/test_relocation.py does not match any files
[NoMissingFiles] 118: .vercel.json does not match any files
[NoMissingFiles] 119: /.githib/worksflows/frontend.yml does not match any files
[NoMissingFiles] 146: /src/sentry/utils/monitors.py does not match any files
[NoMissingFiles] 147: /tests/sentry/utils/test_monitors.py does not match any files
[NoMissingFiles] 162: /src/sentry/api/endpoints/internal/integration_proxy.py does not match any files
[NoMissingFiles] 164: /src/sentry/models/outbox.py does not match any files
[NoMissingFiles] 165: /src/sentry/tasks/deliver_from_outbox.py does not match any files
[NoMissingFiles] 225: /tests/snuba/api/endpoints/test_organization_events_trends_v2.py does not match any files
[NoMissingFiles] 313: /src/sentry/utils/profiling.py does not match any files
[NoMissingFiles] 368: /src/sentry/tasks/weekly_reports.py does not match any files
[NoMissingFiles] 390: /src/sentry/models/organizationoption.py does not match any files
[NoMissingFiles] 392: /src/sentry/models/projectoption.py does not match any files
[NoDuplicatePatterns] 412: /src/sentry/web/frontend/auth_login.py duplicated on line 58
[NoMissingFiles] 421: /tests/sentry/api/test_scim*.py does not match any files
[NoMissingFiles] 445: /tests/sentry/api/endpoints/test_projects_metrics_visibility.py does not match any files
[NoMissingFiles] 451: /src/sentry/api/endpoints/organization_ddm.py does not match any files
[NoMissingFiles] 452: /tests/sentry/api/endpoints/test_organization_ddm_meta.py does not match any files
[NoMissingFiles] 457: /src/sentry/api/endpoints/projects_metrics.py does not match any files
[NoDuplicatePatterns] 477: /src/sentry/snuba/metrics/ duplicated on line 27
[NoMissingFiles] 482: /static/app/actionCreators/metrics.spec.tsx does not match any files
[NoMissingFiles] 492: /static/app/views/performance/landing/dynamicSamplingMetricsAccuracy.spec.tsx does not match any files
[NoMissingFiles] 493: /static/app/views/performance/landing/dynamicSamplingMetricsAccuracyAlert.tsx does not match any files
[NoMissingFiles] 554: /static/app/components/modals/autofixSetupModal.spec.tsx does not match any files
[NoMissingFiles] 555: /static/app/components/modals/autofixSetupModal.tsx does not match any files
[NoMissingFiles] 568: /src/sentry/tasks/low_priority_symbolication.py does not match any files
[NoMissingFiles] 570: /tests/sentry/tasks/test_low_priority_symbolication.py does not match any files
[NoMissingFiles] 571: /src/sentry/tasks/reprocessing.py does not match any files
[NoMissingFiles] 580: /src/sentry/tasks/invite_missing_org_members.py does not match any files
[NoMissingFiles] 582: /src/sentry/tasks/integrations/github/pr_comment.py does not match any files
```
Comment on lines -119 to +117
/.githib/worksflows/frontend.yml @getsentry/owners-js-build
/.github/workflows/frontend.yml @getsentry/owners-js-build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most fun one

@@ -409,7 +400,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/src/sentry/models/release_threshold @getsentry/enterprise
/src/sentry/scim/ @getsentry/enterprise
/src/sentry/tasks/integrations/github/ @getsentry/enterprise
/src/sentry/web/frontend/auth_login.py @getsentry/enterprise
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was hiding the same rule on line 58

@mrduncan mrduncan marked this pull request as ready for review August 23, 2024 16:58
@mrduncan mrduncan requested a review from a team as a code owner August 23, 2024 16:58
@getsantry
Copy link
Contributor

getsantry bot commented Sep 14, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 14, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Oct 7, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 7, 2024
@mrduncan mrduncan closed this Oct 7, 2024
@mrduncan mrduncan deleted the mrduncan/codeowner-cleanup branch October 7, 2024 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant