fix: capture_message does not accept extra #76728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue introduced in #76616.
github-actions
bot
added
the
Scope: Backend
leeandher
reviewed
Aug 29, 2024
| @@ -428,7 +428,7 @@ def _populate_trees_process_error(self, error: ApiError, extra: dict[str, str]) | |||
| else: | |||
| # We do not raise the exception so we can keep iterating through the repos. | |||
| # Nevertheless, investigate the error to determine if we should abort the processing | |||
| capture_message("Continuing execution. Investigate: %s", error_message, extra=extra) | |||
| capture_message("Continuing execution. Investigate: %s", error_message) | |||
There was a problem hiding this comment.
From the docs it looks it doesn't look like capture_message takes a second arg, You can probably swap it for an f-string here. Also could we add the extra back as context with sentry_sdk.set_context? In case it has something important.
leeandher
approved these changes
Aug 29, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76728 +/- ##
==========================================
- Coverage 78.15% 78.15% -0.01%
==========================================
Files 6910 6910
Lines 307199 307200 +1
Branches 50356 50356
==========================================
- Hits 240096 240095 -1
- Misses 60751 60752 +1
- Partials 6352 6353 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced in #76616.