chore(feedback): additional metrics for celery task and shim_to_feedback errors #76750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cmanallen
reviewed
Aug 29, 2024
| @@ -359,6 +359,7 @@ def shim_to_feedback( | |||
| logger.exception( | |||
| "Error attempting to create new User Feedback from Shiming old User Report" | |||
| ) | |||
| metrics.incr("feedback.shim_to_feedback.failed", tags={"referrer": source.value}) | |||
There was a problem hiding this comment.
What is the cardinality of source.value?
cmanallen
approved these changes
Aug 29, 2024
mifu67
pushed a commit
that referenced
this pull request
Sep 3, 2024
…ack errors (#76750) Gives us visibility on effectiveness+failures of update_user_reports task, and shim failures
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives us visibility on effectiveness+failures of update_user_reports task, and shim failures