fix(issues): Avoid animating tags on initial load #76762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On page load the tags animate in and all are rendered regardless of if they're expanded or not. Using AnimatePresence allows us to avoid the initial render animation and skip rendering collapsed tags and their mouse listeners and tooltips.
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #76762 +/- ##
==========================================
+ Coverage 73.64% 78.16% +4.52%
==========================================
Files 6914 6914
Lines 307575 307571 -4
Branches 50431 50429 -2
==========================================
+ Hits 226499 240416 +13917
+ Misses 74557 60777 -13780
+ Partials 6519 6378 -141 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On page load, the tags animate in and all are rendered regardless of if they're expanded or not. Using AnimatePresence allows us to avoid the initial render animation and skip rendering collapsed tags and their mouse listeners and tooltips.
example of route navigation causing a rerender that causes the tags to animate again even thought the data is unchanged.
CleanShot.2024-08-29.at.15.10.14.mp4