ref(whats-new): Revamp "Whats New" #76818

priscilawebdev · 2024-09-02T14:25:39Z

Before

After

codecov · 2024-09-02T14:33:44Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
7734	1	7733	0

View the top 1 failed tests by shortest run time

Broadcasts renders item with media Broadcasts renders item with media

Stack Traces | 0.054s run time

TestingLibraryElementError: Unable to find an element with the text: blog post. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.&lt;anonymous&gt; (.../components/sidebar/broadcasts.spec.tsx:66:40)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

static/app/types/system.tsx

static/app/components/sidebar/broadcasts.tsx

static/app/components/sidebar/sidebarPanelItem.tsx

static/app/components/sidebar/broadcasts.tsx

roggenkemper · 2024-09-05T21:55:37Z

static/app/components/sidebar/utils.tsx


 export const isDone = (task: OnboardingTaskStatus) =>
  task.status === 'complete' || task.status === 'skipped';

 // To be passed as the `source` parameter in router navigation state
 // e.g. {pathname: '/issues/', state: {source: `sidebar`}}
 export const SIDEBAR_NAVIGATION_SOURCE = 'sidebar';
+
+export function hasWhatIsNewRevampFeature(organization: Organization) {
+  return organization.features.includes('what-is-new-revamp');


two nits here - would prefer we call this whats-new-revamp if the flag hasn't been created yet. second, do we really need this util function ? i feel like since it is just a feature flag check we could have it be const hasWhatsNewRevamp = organization.features.includes()...;

yes initially I thought we would use it in more different places but it makes sense

oh and the feature flag has already been created

roggenkemper · 2024-09-05T21:56:32Z

static/app/types/system.tsx

-};
+  /**
+   * Category of the broadcast.
+   * Synced with https://github.com/getsentry/sentry/blob/923a65508912c3e181e1c70cbdf076b7b956aa90/src/sentry/models/broadcast.py#L14


can we change the branch here to be master: https://github.com/getsentry/sentry/blob/master/src/sentry/models/broadcast.py

~~I tried that a couple of times, but always when I clicked on the copy button I got a blob/code~~ never mind... copying the URL works too

sentry-io · 2024-09-13T18:23:28Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ TypeError: Cannot destructure property 'basename' of 'React__namespace.useContext(...)' as it is null. render(reactTestingLibrary.tsx) View Issue

_{Did you find this useful? React with a 👍 or 👎}

ref(whats-new): Add improvements

d40550c

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 2, 2024

vercel bot deployed to Preview September 2, 2024 14:28 View deployment

priscilawebdev added 4 commits September 3, 2024 13:58

Merge branch 'master' into priscila/ref/whats-new/improvements

c546c6d

fix types

af17700

minor improvement

991aeae

Merge branch 'master' into priscila/ref/whats-new/improvements

3b892a0

vercel bot deployed to Preview September 3, 2024 13:03 View deployment

priscilawebdev added 2 commits September 3, 2024 16:25

polish + tests

70a8fda

remove ;

01451b9

priscilawebdev marked this pull request as ready for review September 3, 2024 14:28

priscilawebdev requested review from roggenkemper and a team September 3, 2024 14:28

vercel bot deployed to Preview September 3, 2024 14:32 View deployment

priscilawebdev commented Sep 3, 2024

View reviewed changes

static/app/types/system.tsx Outdated Show resolved Hide resolved

Merge branch 'master' into priscila/ref/whats-new/improvements

6fbc2f5

vercel bot deployed to Preview September 4, 2024 08:23 View deployment

fix types

f6e4b7b

vercel bot deployed to Preview September 4, 2024 11:35 View deployment

fix test

108efa8

vercel bot deployed to Preview September 4, 2024 12:45 View deployment

imageURL is required

65f0381

vercel bot deployed to Preview September 4, 2024 12:49 View deployment

roggenkemper reviewed Sep 4, 2024

View reviewed changes

static/app/components/sidebar/broadcasts.tsx Outdated Show resolved Hide resolved

roggenkemper reviewed Sep 4, 2024

View reviewed changes

static/app/components/sidebar/sidebarPanelItem.tsx Outdated Show resolved Hide resolved

priscilawebdev marked this pull request as draft September 5, 2024 08:36

priscilawebdev added 2 commits September 5, 2024 11:21

Merge branch 'master' into priscila/ref/whats-new/improvements

458fee5

make props optional

7dbbef6

vercel bot deployed to Preview September 5, 2024 09:34 View deployment

update test

dd7a508

vercel bot deployed to Preview September 5, 2024 09:38 View deployment

priscilawebdev commented Sep 5, 2024

View reviewed changes

static/app/components/sidebar/broadcasts.tsx Outdated Show resolved Hide resolved

priscilawebdev added 3 commits September 5, 2024 11:40

Update static/app/components/sidebar/broadcasts.tsx

2f1422f

revert sidebarpanel

407d12d

fix prop

deaa5c1

vercel bot deployed to Preview September 5, 2024 09:47 View deployment

priscilawebdev marked this pull request as ready for review September 5, 2024 13:22

priscilawebdev added 2 commits September 5, 2024 21:45

Merge branch 'master' into priscila/ref/whats-new/improvements

8e06a98

implemented new styles

4442ed5

vercel bot deployed to Preview September 5, 2024 21:03 View deployment

update comment

5a0586a

priscilawebdev requested a review from roggenkemper September 5, 2024 21:09

vercel bot deployed to Preview September 5, 2024 21:12 View deployment

roggenkemper reviewed Sep 5, 2024

View reviewed changes

priscilawebdev added 3 commits September 6, 2024 08:29

Merge branch 'master' into priscila/ref/whats-new/improvements

1c19edd

feedback

74cf7d8

update comment

3129e46

priscilawebdev requested a review from roggenkemper September 6, 2024 06:33

vercel bot deployed to Preview September 6, 2024 06:37 View deployment

priscilawebdev changed the title ~~ref(whats-new): Add improvements~~ ref(whats-new): Revamp "Whats New" Sep 6, 2024

matejminar approved these changes Sep 6, 2024

View reviewed changes

priscilawebdev merged commit 396d044 into master Sep 6, 2024
45 checks passed

priscilawebdev deleted the priscila/ref/whats-new/improvements branch September 6, 2024 11:13

c298lee pushed a commit that referenced this pull request Sep 10, 2024

ref(whats-new): Revamp "Whats New" (#76818)

f3a0456

github-actions bot locked and limited conversation to collaborators Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref(whats-new): Revamp "Whats New" #76818

ref(whats-new): Revamp "Whats New" #76818

priscilawebdev commented Sep 2, 2024 •

edited

Loading

codecov bot commented Sep 2, 2024 •

edited

Loading

roggenkemper Sep 5, 2024

priscilawebdev Sep 6, 2024

priscilawebdev Sep 6, 2024 •

edited

Loading

roggenkemper Sep 5, 2024

priscilawebdev Sep 6, 2024 •

edited

Loading

sentry-io bot commented Sep 13, 2024

ref(whats-new): Revamp "Whats New" #76818

ref(whats-new): Revamp "Whats New" #76818

Conversation

priscilawebdev commented Sep 2, 2024 • edited Loading

codecov bot commented Sep 2, 2024 • edited Loading

❌ 1 Tests Failed:

roggenkemper Sep 5, 2024

Choose a reason for hiding this comment

priscilawebdev Sep 6, 2024

Choose a reason for hiding this comment

priscilawebdev Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

roggenkemper Sep 5, 2024

Choose a reason for hiding this comment

priscilawebdev Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

sentry-io bot commented Sep 13, 2024

Suspect Issues

priscilawebdev commented Sep 2, 2024 •

edited

Loading

codecov bot commented Sep 2, 2024 •

edited

Loading

priscilawebdev Sep 6, 2024 •

edited

Loading

priscilawebdev Sep 6, 2024 •

edited

Loading