test(alerts): Debug anomaly detection #77109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
commented
Sep 6, 2024
| expected_seasonality=alert_rule.seasonality, | ||
| ) | ||
| ############################ | ||
| now = datetime.datetime.now() |
There was a problem hiding this comment.
Since I don't have access to self.last_update from the subscription processor, I am using the current timestamp
ceorourke
commented
Sep 6, 2024
| @@ -103,7 +104,10 @@ def format_historical_data(data: SnubaTSResult, dataset: Any) -> list[TimeSeries | |||
| formatted_data.append(ts_point) | |||
| else: | |||
| for datum in nested_data: | |||
| ts_point = TimeSeriesPoint(timestamp=datum.get("time"), value=datum.get("count", 0)) | |||
| ######################### | |||
| count = randrange(1, 100) | |||
There was a problem hiding this comment.
There is no historical data locally so I populate this with random numbers. Seer wasn't happy if I did it all the same number. Put this back to falling back to 0 to test the 500 error we were getting
❌ 54 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not actually code that will be merged, but since we can't test metric alerts locally fully I pulled out the code we are having trouble with in production to be able to test it locally and make sure everything is working.