Set local clickhouse container's hostname to clickhouse.dev.local #77125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a clickhouse container is running locally, its hostname is randomly picked up by docker runtime. This hostname which also happens to be the container-id is 12 characters long and composed solely of hexadecimal digits. This makes the hostname resolution a problem because the id is dynamically generated and can be only controlled by docker runtime. This PR sets clickhouse container's hostname to
clickhouse.dev.local
.In Snuba developement environment, snuba admin is often not run as a docker container on Mac. To resolve the hostnmae from Snuba admin, you have an entry
127.0.0.1 clickhouse.dev.local
in/etc/hosts
and thenclickhouse.dev.local
can resolve to127.0.0.1
. On Mac,127.0.0.1
's port9000
is forwarded to the clickhouse container, thus making it possible to connect to that container.The corresponding changes in Snuba admin are in getsentry/snuba#6268.
Testing done