Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): support browser.request span for reparenting #77176

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Sep 9, 2024

Add reparenting support for the incoming renaming change in getsentry/sentry-javascript#13527

@JonasBa JonasBa requested a review from a team as a code owner September 9, 2024 19:24
@JonasBa JonasBa requested review from lforst and Abdkhan14 and removed request for a team September 9, 2024 19:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 9, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77176      +/-   ##
==========================================
- Coverage   78.17%   78.16%   -0.02%     
==========================================
  Files        6927     6930       +3     
  Lines      307842   307897      +55     
  Branches    50426    50439      +13     
==========================================
+ Hits       240656   240659       +3     
- Misses      60786    60829      +43     
- Partials     6400     6409       +9     

@JonasBa JonasBa merged commit 0dddd89 into master Sep 10, 2024
44 checks passed
@JonasBa JonasBa deleted the jb/trace/browser-request-reparenting branch September 10, 2024 13:39
c298lee pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants