ref(replay): try 5s rage/dead click timeout for select orgs, using options #77325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Sep 11, 2024
True! This is all backend tho so we can just do 1 PR w/2 options |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
cmanallen
requested changes
Sep 11, 2024
| organization = Project.objects.get(id=project_id).organization | ||
| dead_click_timeout = ( | ||
| reduced_dead_click_timeout | ||
| if organization.slug in options.get("feedback.dead-click.reduced-timeout-org-list") |
There was a problem hiding this comment.
Let's not use the org slug because we need to query for it. We have the org_id and the project_id. We could use those with the option directly so you don't need to query anything.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
aliu39
added a commit
that referenced
this pull request
Oct 18, 2024
Reopened from #77325. Follows up on a slack thread from a while ago with @drguthals and @bruno-garcia. Once this is merged, we can specify a list of org IDs (e.g. sentry orgs) and any timeout we want. Note we still need a way to pass the org_id from [recording_buffered.py](https://github.com/getsentry/sentry/blob/06884c96f61f9fb30d02ef41d833299123a3e23b/src/sentry/replays/consumers/recording_buffered.py#L323-L323)
harshithadurai
pushed a commit
that referenced
this pull request
Oct 19, 2024
Reopened from #77325. Follows up on a slack thread from a while ago with @drguthals and @bruno-garcia. Once this is merged, we can specify a list of org IDs (e.g. sentry orgs) and any timeout we want. Note we still need a way to pass the org_id from [recording_buffered.py](https://github.com/getsentry/sentry/blob/06884c96f61f9fb30d02ef41d833299123a3e23b/src/sentry/replays/consumers/recording_buffered.py#L323-L323)
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Reopened from #77325. Follows up on a slack thread from a while ago with @drguthals and @bruno-garcia. Once this is merged, we can specify a list of org IDs (e.g. sentry orgs) and any timeout we want. Note we still need a way to pass the org_id from [recording_buffered.py](https://github.com/getsentry/sentry/blob/06884c96f61f9fb30d02ef41d833299123a3e23b/src/sentry/replays/consumers/recording_buffered.py#L323-L323)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #77286 and #77284
Depends on #77365