fix(replay): CLS score is not in ms #77397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
k-fish
reviewed
Sep 12, 2024
Comment on lines
289
to
292
| description: tct('[value][ms] (Good)', { | ||
| value: frame.data.value.toFixed(2), | ||
| ms: frame.description === 'cumulative-layout-shift' ? '' : 'ms', | ||
| }), |
There was a problem hiding this comment.
This could perhaps be [unit] and have a function that returns a unit based on the frame description, but realistically only CLS will be non-ms
k-fish
approved these changes
Sep 12, 2024
michellewzhang
approved these changes
Sep 12, 2024
| value: frame.data.value.toFixed(2), | ||
| ms: frame.description === 'cumulative-layout-shift' ? '' : 'ms', |
There was a problem hiding this comment.
small nit: could move this into a constant to avoid having to type this ternary out 3 times
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
michellewzhang
approved these changes
Sep 12, 2024
mifu67
pushed a commit
that referenced
this pull request
Sep 12, 2024
If the web vital is CLS, don't include `ms`. CLS is the only web vital in replays that isn't measured in milliseconds. Relates to #69881
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the web vital is CLS, don't include
ms. CLS is the only web vital in replays that isn't measured in milliseconds.Relates to #69881