Add DataConditions for workflow_engine #77448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
This PR has a migration; here is the generated SQL for --
-- Create model DataCondition
--
CREATE TABLE "workflow_engine_datacondition" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NOT NULL, "condition" varchar(200) NOT NULL, "threshold" double precision NOT NULL, "condition_result" jsonb NOT NULL, "type" varchar(200) NOT NULL, "detectors_id" bigint NOT NULL, "workflow_action_id" bigint NOT NULL);
ALTER TABLE "workflow_engine_datacondition" ADD CONSTRAINT "workflow_engine_data_detectors_id_d9f45fc7_fk_workflow_" FOREIGN KEY ("detectors_id") REFERENCES "workflow_engine_detector" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_datacondition" VALIDATE CONSTRAINT "workflow_engine_data_detectors_id_d9f45fc7_fk_workflow_";
ALTER TABLE "workflow_engine_datacondition" ADD CONSTRAINT "workflow_engine_data_workflow_action_id_7d1dcfde_fk_workflow_" FOREIGN KEY ("workflow_action_id") REFERENCES "workflow_engine_workflowaction" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_datacondition" VALIDATE CONSTRAINT "workflow_engine_data_workflow_action_id_7d1dcfde_fk_workflow_";
CREATE INDEX CONCURRENTLY "workflow_engine_datacondition_detectors_id_d9f45fc7" ON "workflow_engine_datacondition" ("detectors_id");
CREATE INDEX CONCURRENTLY "workflow_engine_datacondition_workflow_action_id_7d1dcfde" ON "workflow_engine_datacondition" ("workflow_action_id"); |
❌ 1467 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
4bc1003
to
fc5cf8e
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
fc5cf8e
to
453c7ee
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
453c7ee
to
448c9aa
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
448c9aa
to
5266e33
Compare
|
This PR has a migration; here is the generated SQL for --
-- Create model DataCondition
--
CREATE TABLE "workflow_engine_datacondition" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NOT NULL, "condition" varchar(200) NOT NULL, "threshold" double precision NOT NULL, "condition_result" jsonb NOT NULL, "type" varchar(200) NOT NULL, "detector_id" bigint NOT NULL, "workflow_action_id" bigint NOT NULL);
ALTER TABLE "workflow_engine_datacondition" ADD CONSTRAINT "workflow_engine_data_detector_id_c0979477_fk_workflow_" FOREIGN KEY ("detector_id") REFERENCES "workflow_engine_detector" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_datacondition" VALIDATE CONSTRAINT "workflow_engine_data_detector_id_c0979477_fk_workflow_";
ALTER TABLE "workflow_engine_datacondition" ADD CONSTRAINT "workflow_engine_data_workflow_action_id_7d1dcfde_fk_workflow_" FOREIGN KEY ("workflow_action_id") REFERENCES "workflow_engine_workflowaction" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_datacondition" VALIDATE CONSTRAINT "workflow_engine_data_workflow_action_id_7d1dcfde_fk_workflow_";
CREATE INDEX CONCURRENTLY "workflow_engine_datacondition_detector_id_c0979477" ON "workflow_engine_datacondition" ("detector_id");
CREATE INDEX CONCURRENTLY "workflow_engine_datacondition_workflow_action_id_7d1dcfde" ON "workflow_engine_datacondition" ("workflow_action_id"); |
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
391c1f0
to
1531f7b
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
4b2a71a
to
637d4af
Compare
|
This PR has a migration; here is the generated SQL for --
-- Create model DataConditionGroup
--
CREATE TABLE "workflow_engine_dataconditiongroup" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NOT NULL, "logic_type" varchar(200) NOT NULL, "detector_id" bigint NULL, "workflow_action_id" bigint NULL);
ALTER TABLE "workflow_engine_dataconditiongroup" ADD CONSTRAINT "workflow_engine_data_detector_id_5b8d9491_fk_workflow_" FOREIGN KEY ("detector_id") REFERENCES "workflow_engine_detector" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_dataconditiongroup" VALIDATE CONSTRAINT "workflow_engine_data_detector_id_5b8d9491_fk_workflow_";
ALTER TABLE "workflow_engine_dataconditiongroup" ADD CONSTRAINT "workflow_engine_data_workflow_action_id_600a68ea_fk_workflow_" FOREIGN KEY ("workflow_action_id") REFERENCES "workflow_engine_workflowaction" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_dataconditiongroup" VALIDATE CONSTRAINT "workflow_engine_data_workflow_action_id_600a68ea_fk_workflow_";
CREATE INDEX CONCURRENTLY "workflow_engine_dataconditiongroup_detector_id_5b8d9491" ON "workflow_engine_dataconditiongroup" ("detector_id");
CREATE INDEX CONCURRENTLY "workflow_engine_dataconditiongroup_workflow_action_id_600a68ea" ON "workflow_engine_dataconditiongroup" ("workflow_action_id");
--
-- Create model DataCondition
--
CREATE TABLE "workflow_engine_datacondition" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NOT NULL, "condition" varchar(200) NOT NULL, "threshold" double precision NOT NULL, "condition_result" jsonb NOT NULL, "type" varchar(200) NOT NULL, "condition_group_id" bigint NOT NULL);
ALTER TABLE "workflow_engine_datacondition" ADD CONSTRAINT "workflow_engine_data_condition_group_id_122daf08_fk_workflow_" FOREIGN KEY ("condition_group_id") REFERENCES "workflow_engine_dataconditiongroup" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "workflow_engine_datacondition" VALIDATE CONSTRAINT "workflow_engine_data_condition_group_id_122daf08_fk_workflow_";
CREATE INDEX CONCURRENTLY "workflow_engine_datacondition_condition_group_id_122daf08" ON "workflow_engine_datacondition" ("condition_group_id"); |
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
057baf8
to
259fef9
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
259fef9
to
784d5c6
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
784d5c6
to
8cde9cb
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
8cde9cb
to
1aa4e69
Compare
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
1aa4e69
to
3489a07
Compare
saponifi3d
commented
Sep 18, 2024
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
3489a07
to
7d15b8c
Compare
wedamija
reviewed
Sep 18, 2024
|
|
||
| condition = models.CharField(max_length=200) | ||
| threshold = models.FloatField() | ||
| condition_result = models.JSONField() |
There was a problem hiding this comment.
How are we planning to handle the schema for this?
There was a problem hiding this comment.
This schema would just be a primitive value; either a string for the detector or boolean for the workflow actions. i can imagine some other scenarios that having this be flexible as a json primitive - but it should never be a compex object / array etc.
is there a good way to enforce that? (off the top of my head, we could have a pre-save signal that validates it's a primitive or throws an exception? 🤔)
| @region_silo_model | ||
| class DataConditionGroup(DefaultFieldsModel): | ||
| """ | ||
| A data condition is a way to specify a condition that must be met for a workflow to execute. |
There was a problem hiding this comment.
A data group is a way to specify a group of conditions that must be met for a workflow action to execute
Comment on lines
26
to
28
| workflow_action = models.ForeignKey( | ||
| WorkflowAction, on_delete=models.CASCADE, blank=True, null=True | ||
| ) |
There was a problem hiding this comment.
Shouldn't we allow multiple workflow actions to be linked here? So this group of conditions fires this group of actions?
…ated a new model called data condition group which will also store logic gates for the data conditions
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
7d15b8c
to
a53b0ef
Compare
- Changed workflow_action to be action, and more generic. will use this to emit events on detectors or send notifications in workflows - Created lookup tables; detector_workflow and workflow_data_condition_group - Updated detector and workflow models to represent new design
saponifi3d
force-pushed
the
jcallender/aci-data-conditions
branch
from
a53b0ef
to
c06a163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
📜 Technical spec
PR Changes
DataConditionwith a 1 to many relationship forDataConditionGroupsthe Group model allows us to defineANYandALL, and group the conditions for evaluation.