feat(eap): Use RPC to fetch tag values #77510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses RPC calls to fetch tag keys from eap spans.
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Sep 13, 2024
| meta=RequestMeta( | ||
| organization_id=organization.id, | ||
| cogs_category="performance", | ||
| referrer=Referrer.API_SPANS_TAG_KEYS.value, |
There was a problem hiding this comment.
nit: should we use a different referrer than the usual query so its easier to differentiate
Comment on lines
+228
to
+232
| times_seen=None, | ||
| first_seen=None, | ||
| last_seen=None, |
There was a problem hiding this comment.
Are these all None cause its not something we can query yet? if so could we add a TODO comment
This uses RPC calls to fetch tag values from eap spans.
Zylphrex
force-pushed
the
txiao/feat/use-rpc-to-fetch-tag-values
branch
from
bd8a1e0
to
ff2d113
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77510 +/- ##
==========================================
+ Coverage 78.08% 78.14% +0.06%
==========================================
Files 6974 6957 -17
Lines 309457 308830 -627
Branches 50659 50543 -116
==========================================
- Hits 241631 241344 -287
+ Misses 61396 61085 -311
+ Partials 6430 6401 -29 |
Base automatically changed from
txiao/feat/use-rpc-to-fetch-tag-keys
to
master
September 17, 2024 18:03
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: bb3cbc3 |
getsentry-bot
added a commit
that referenced
this pull request
Sep 27, 2024
This reverts commit a8e4e05. Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses RPC calls to fetch tag values from eap spans.
depends on getsentry/snuba#6304