feat(replays): Add optimized tag search #77595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77595 +/- ##
===========================================
- Coverage 88.40% 78.14% -10.27%
===========================================
Files 2998 6972 +3974
Lines 186455 309396 +122941
Branches 30635 50622 +19987
===========================================
+ Hits 164837 241779 +76942
- Misses 15599 61200 +45601
- Partials 6019 6417 +398 |
JoshFerge
approved these changes
Sep 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tags search is expensive from a bytes and rows scanned perspective. This optimization makes it so that single tag searches can be run quickly and efficiently.
Depends on: getsentry/snuba#6308 and getsentry/snuba#6309
Related: #76289