Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure Sentry SDK is always bumped by dependabot #77678

Closed
wants to merge 1 commit into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 18, 2024

I was wondering why the SDK is not automatically kept up-to-date by dependabot. After looking into it, I guess the problem is that the limit is set to 10 open PRs that are generally there (some have been open for months), so there is no capacity to open new ones.

As we'd love to have the SDK be up to date generally, this PR splits the SDK updates out to not have a limit. Hopefully that should ensure that we generally have this at latest.

@mydea mydea self-assigned this Sep 18, 2024
@mydea mydea requested a review from a team as a code owner September 18, 2024 07:45
@mydea mydea requested review from scttcper and billyvg and removed request for a team September 18, 2024 07:45
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 18, 2024
Comment on lines +63 to +65
# For Sentry SDK updates, we do not want to limit the open PRs
- package-ecosystem: npm
open-pull-requests-limit: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it works like this -- last we tried you can only have one npm section in a dependabot config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah damn, that sucks - I thought that would work :( does that mean it is not possible to realize this? 😬
What are thoughts about increasing the PR limit (10), or finding a different way to deal with those? As of now dependabot seems basically blocked because of open PRs with low prio 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik for packages we care about we've just been doing them periodically on our own. dependabot isn't very good at bumping packages anyway (lol I know right?) so it's been smoother when a person does it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I mean this is what we kind of did so far, but we always lag behind a bit with the SDK and it would be nice to be up-to-date there, as it is our premier dogfooding app as well 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah doesn't seem to be supported: dependabot/dependabot-core#1778

Though looks like there's a workaround if you have one config set target-branch: master

@scttcper
Copy link
Member

i usually see it make one for sentry dependencies. there's one open here #77287

@mydea mydea closed this Sep 19, 2024
@mydea mydea deleted the fn/dependabot-sdk branch September 19, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants