Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(useOnboardingQueryParams): Remove showLoader #77699

Merged

Conversation

priscilawebdev
Copy link
Member

with the script loader code in the javascript file, we no longer need this code

…' into priscila/ref/onboarding/move-loader-code
…:getsentry/sentry into priscila/ref/onboarding/move-loader-code
…:getsentry/sentry into priscila/ref/onboarding/move-loader-code
…:getsentry/sentry into priscila/ref/onboarding/move-loader-code
@priscilawebdev priscilawebdev requested a review from a team as a code owner September 18, 2024 15:14
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
7803 2 7801 0
View the top 2 failed tests by shortest run time
Onboarding Product Selection renders for Loader Script Onboarding Product Selection renders for Loader Script
Stack Traces | 0.034s run time
TestingLibraryElementError: Unable to find an element with the text: function (_, element) { return findTextWithMarkup(element, textMatch); } (normalized from 'function (_, element) {
    return findTextWithMarkup(element, textMatch);
  }'). This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../components/onboarding/productSelection.spec.tsx:136:40)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
Onboarding Setup Docs JS Loader Script renders Loader Script setup Onboarding Setup Docs JS Loader Script renders Loader Script setup
Stack Traces | 0.266s run time
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../views/onboarding/setupDocs.spec.tsx:373:32)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Base automatically changed from priscila/ref/onboarding/move-loader-code to master September 23, 2024 06:43
@priscilawebdev priscilawebdev enabled auto-merge (squash) September 23, 2024 07:05
@priscilawebdev priscilawebdev merged commit a2db6bb into master Sep 23, 2024
41 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/onboarding/remove-loader-use-query-params branch September 23, 2024 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants