-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(useOnboardingQueryParams): Remove showLoader #77699
Merged
priscilawebdev
merged 26 commits into
master
from
priscila/ref/onboarding/remove-loader-use-query-params
Sep 23, 2024
Merged
ref(useOnboardingQueryParams): Remove showLoader #77699
priscilawebdev
merged 26 commits into
master
from
priscila/ref/onboarding/remove-loader-use-query-params
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cila/ref/onboarding/move-loader-code
…' into priscila/ref/onboarding/move-loader-code
…:getsentry/sentry into priscila/ref/onboarding/move-loader-code
…:getsentry/sentry into priscila/ref/onboarding/move-loader-code
…:getsentry/sentry into priscila/ref/onboarding/move-loader-code
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Sep 18, 2024
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
obostjancic
approved these changes
Sep 18, 2024
Base automatically changed from
priscila/ref/onboarding/move-loader-code
to
master
September 23, 2024 06:43
priscilawebdev
deleted the
priscila/ref/onboarding/remove-loader-use-query-params
branch
September 23, 2024 07:22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the script loader code in the javascript file, we no longer need this code