Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Config stub for span.op inference #77851

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Sep 20, 2024

Add a first rule to derive missing span.ops in Relay.

See getsentry/relay#4056, getsentry/relay#3637.

Closes getsentry/relay#3637.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 20, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77851      +/-   ##
==========================================
+ Coverage   78.10%   78.14%   +0.04%     
==========================================
  Files        7076     7072       -4     
  Lines      311942   311628     -314     
  Branches    50939    50901      -38     
==========================================
- Hits       243648   243529     -119     
+ Misses      61940    61744     -196     
- Partials     6354     6355       +1     

@jjbayer jjbayer changed the base branch from master to chore/relay-0.9.2 October 1, 2024 08:42
Base automatically changed from chore/relay-0.9.2 to master October 1, 2024 09:40
@jjbayer jjbayer marked this pull request as ready for review October 1, 2024 10:43
@jjbayer jjbayer requested a review from a team as a code owner October 1, 2024 10:43
@jjbayer jjbayer requested a review from mydea October 1, 2024 10:46
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is covered by one of the roundtrip tests?

@jjbayer
Copy link
Member Author

jjbayer commented Oct 2, 2024

I assume this is covered by one of the roundtrip tests?

Yes, test_global_config.

@jjbayer jjbayer merged commit 42cb4be into master Oct 3, 2024
50 checks passed
@jjbayer jjbayer deleted the feat/spans-infer-op branch October 3, 2024 07:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Valid Span Op names instead of default
2 participants