Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(insights): fix broken issue link #77868

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(insights): fix broken issue link #77868

merged 1 commit into from
Sep 20, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Sep 20, 2024 •
edited
Loading

if no event_id is passed into the component, then don't render a specific event page.

before:

Screen.Recording.2024-09-20.at.1.31.25.PM.mov

after:

Screen.Recording.2024-09-20.at.1.31.39.PM.mov

@michellewzhang michellewzhang requested review from a team as code owners September 20, 2024 20:33
@michellewzhang michellewzhang requested a review from a team September 20, 2024 20:33
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 20, 2024
billyvg
billyvg approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why there was no event_id?

@michellewzhang
Copy link
Member Author

Do we know why there was no event_id?

we don't have access to the event in this component, i think we'd need an extra api query

gggritso
gggritso approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michellewzhang michellewzhang merged commit 972b13a into master Sep 20, 2024
44 checks passed
@michellewzhang michellewzhang deleted the mz/insights-link branch September 20, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@ryan953 ryan953 ryan953 approved these changes

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellewzhang @billyvg @ryan953 @gggritso