Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autofix): Add clean error handling, keyboard support in message box #77873

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

roaga
Copy link
Member

@roaga roaga commented Sep 20, 2024

  • You can use the return key in the message box to send the message now
  • Cleanly displays errors and step retries
  • Small copy change
Screenshot 2024-09-20 at 1 47 37 PM

@roaga roaga requested a review from a team as a code owner September 20, 2024 20:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tic/app/components/events/autofix/autofixSteps.tsx 25.00% 1 Missing and 2 partials ⚠️
...pp/components/events/autofix/autofixMessageBox.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #77873       +/-   ##
===========================================
- Coverage   88.40%   78.12%   -10.28%     
===========================================
  Files        3000     6994     +3994     
  Lines      186662   310207   +123545     
  Branches    30663    50753    +20090     
===========================================
+ Hits       165012   242349    +77337     
- Misses      15621    56132    +40511     
- Partials     6029    11726     +5697     

@roaga roaga merged commit 223d186 into master Sep 20, 2024
43 of 44 checks passed
@roaga roaga deleted the autofix/ui branch September 20, 2024 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants