feat(issue-views): Update banner and tooltip copy, make banner dismissable, feedback -> read docs #77878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77878 +/- ##
==========================================
- Coverage 78.12% 78.09% -0.03%
==========================================
Files 6991 7007 +16
Lines 310002 310474 +472
Branches 50724 50795 +71
==========================================
+ Hits 242182 242464 +282
- Misses 56101 56282 +181
- Partials 11719 11728 +9 |
| <Title> | ||
| {t('Welcome to the new Issue Views experience (Early Adopter only)')} | ||
| <DismissButton | ||
| analyticsEventKey="issue_views.add_view.banner_dismissed" |
There was a problem hiding this comment.
if the button is the only place you are using this analytics event key, you don't need to define it in issueAnalyticsEvents
malwilley
reviewed
Sep 24, 2024
malwilley
reviewed
Sep 24, 2024
MichaelSun48
added a commit
that referenced
this pull request
Sep 24, 2024
Adds the prompt for the add view banner [related PR](#77878)
Bundle ReportChanges will increase total bundle size by 2.67kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
malwilley
approved these changes
Sep 25, 2024
0Calories
pushed a commit
that referenced
this pull request
Sep 25, 2024
Adds the prompt for the add view banner [related PR](#77878)
MichaelSun48
force-pushed
the
msun/issueViews/addViewEAReadiness
branch
from
11225b5
to
6378047
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a couple changes to the add view page for EA readiness:
IMPORTANT: Issue views docs have not been merged in yet, so the docs links are broken. I will not merge this until the docs links resolve. Docs PR if you're curious about it.