Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry_apps): Move over internal_token & stats endpoints to sentry_apps #77888

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Sep 22, 2024

migrate internal sentry app & stats related endpoints to sentry_apps!
[X] endpoints
[X] tests
[x] typing - relies on installation endpts pr (#77869)
[x] getsentry shim - kinda -> import internal_token in barrel file of sentry/api/endpoints/integrations/sentry_apps

issue ref(#73857)

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try_apps/api/endpoints/sentry_app_stats_details.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77888      +/-   ##
==========================================
+ Coverage   78.12%   78.14%   +0.02%     
==========================================
  Files        6997     6994       -3     
  Lines      310400   310242     -158     
  Branches    50780    50714      -66     
==========================================
- Hits       242494   242451      -43     
+ Misses      56177    56091      -86     
+ Partials    11729    11700      -29     

@Christinarlong Christinarlong marked this pull request as ready for review September 24, 2024 17:26
@Christinarlong Christinarlong requested review from a team as code owners September 24, 2024 17:26
@Christinarlong Christinarlong merged commit 085d295 into master Sep 24, 2024
51 checks passed
@Christinarlong Christinarlong deleted the christinarlong/move-sentryapps-endpoints-rest branch September 24, 2024 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants