-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(stats): Add links to the stats docs #77897
Conversation
@@ -265,7 +267,23 @@ class UsageStatsOrganization< | |||
isLoading: loading, | |||
isError: hasError, | |||
errors: chartErrors, | |||
title: ' ', // Force the title to be blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leedongwei I saw that you added this change here. Do you remember why we decided not to render the chart's title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a design decision.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #77897 +/- ##
==========================================
- Coverage 78.12% 77.99% -0.14%
==========================================
Files 6996 6995 -1
Lines 310230 310211 -19
Branches 50765 50763 -2
==========================================
- Hits 242367 241947 -420
+ Misses 56144 56133 -11
- Partials 11719 12131 +412 |
closes #76791
Screen.Recording.2024-09-23.at.10.09.02.mov