Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(stats): Add links to the stats docs #77897

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Sep 23, 2024

closes #76791

Screen.Recording.2024-09-23.at.10.09.02.mov

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 23, 2024
@@ -265,7 +267,23 @@ class UsageStatsOrganization<
isLoading: loading,
isError: hasError,
errors: chartErrors,
title: ' ', // Force the title to be blank
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leedongwei I saw that you added this change here. Do you remember why we decided not to render the chart's title?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a design decision.

@priscilawebdev priscilawebdev changed the title ref(stats): Add links to docs ref(stats): Add links to the stats docs Sep 23, 2024
@priscilawebdev priscilawebdev requested review from a team and leedongwei September 23, 2024 08:18
@priscilawebdev priscilawebdev marked this pull request as ready for review September 23, 2024 08:18
@priscilawebdev priscilawebdev requested a review from a team as a code owner September 23, 2024 08:18
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77897      +/-   ##
==========================================
- Coverage   78.12%   77.99%   -0.14%     
==========================================
  Files        6996     6995       -1     
  Lines      310230   310211      -19     
  Branches    50765    50763       -2     
==========================================
- Hits       242367   241947     -420     
+ Misses      56144    56133      -11     
- Partials    11719    12131     +412     

@priscilawebdev priscilawebdev merged commit a6c5635 into master Sep 25, 2024
43 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/stats/add-links-to-docs branch September 25, 2024 07:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brainstorming how to link stats docs to chart reasons
3 participants