fix(perf): Prevents settings route from marking "Performance" in sidebar as active #77946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a `/settings/projects/<project-slug>performance/` URL that activates the "Performance" sidebar item because it's using an inexact URL match. Omit Settings pages.
github-actions
bot
added
the
Scope: Frontend
vgrozdanic
approved these changes
Sep 23, 2024
|
Should we do this also for other URLs that do not have There might be some other projects which could cause buggy behaviour if the name matches one of our url paths |
|
@vgrozdanic definitely maybe! I don't know if any other URLs in-app have matching Settings routes (or other conflicting rules overall) I'd rather just patch this one thing for now and use router-native active links if possible and solve this once and for all (though I don't know why we're not doing that and how much work it is to implement that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a
/settings/projects/<project-slug>performance/URL that activates the "Performance" sidebar item because it's using an inexact URL match. Omit Settings pages the same way other paths do this. Yucky but works for now!Before:
You can see both "Performance" and "Settings" are active, gross.