fix(visibility): Look for field meta on data['meta']['fields']
#77951
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discover responses look like this:
You can see that field types are on the
meta.fields
object. However, the field renderers look for field types like this:They're just looking for keys on
meta
itself! This is because Discover data fetchers do this:I don't know why! I'm curious to know why. However, regardless of why, field renderers should attempt to find field definitions on the
data.meta.fields
object, if it exists. This makes it easier to use field renderes on Discover responses regardless of context (e.g., in the new data visualization widget components)